김재연_JohnLemon 과제제출#6
Open
0xwiederholen wants to merge 11 commits intoXREAL-SNU:jaeyeonfrom
Open
Conversation
0xwiederholen
commented
Mar 26, 2022
0xwiederholen
commented
- 지금까지 구글링 하며 찔끔씩 익혔던 것들 + 몰랐던 기능들을 전체적으로 다 훑어보고 정리할 수 있었던 과제였던 것 같습니다. 😀 알면 알수록 공부할게 더 많아지는 것..같지만..ㅠㅠㅠ 뭘 더 공부해야 할지 정리된 느낌입니다😊
- 지금껏 그냥 코드 복붙했던 기본적인 rotation과 transform 의 코드를 자세히 이해하려 하니 조금 어려웠는데 확실히 이해될 수 있어서 좋았습니다.
- 화이띵..!ㅇvㅇ
- add john lemmon character - add walking animation - apply rigid body and collider
add playerMovement script
- add ui background image and exit image
MondaySHB
reviewed
Mar 27, 2022
MondaySHB
left a comment
MondaySHB
left a comment
There was a problem hiding this comment.
복붙하셨던 code를 이해하셨다고 하기에 너무 잘 작성해주신 거 같습니다!!
(git commit message에서 연륜이 묻어 나시네요 ㅎㅎㅎ)
| { | ||
| m_AudioSource.Stop(); | ||
| } | ||
| Vector3 desiredForward = Vector3.RotateTowards(transform.forward, m_Movement, turnSpeed * Time.deltaTime, 0f); |
There was a problem hiding this comment.
rotation, transform 코드 이해하시느라 고생 많으셨습니다!!
| m_AudioSource = GetComponent<AudioSource>(); | ||
| } | ||
|
|
||
| void FixedUpdate() |
There was a problem hiding this comment.
transform, rotate와 같은 물리적 동작에 time value가 들어가면 frame 수를 맞춰주기 위해 fixedUpdate로 구현합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.