서동재_JohnLemon 과제 제출#8
Open
arsenalis4 wants to merge 6 commits intoXREAL-SNU:dongjaefrom
Open
Conversation
MondaySHB
reviewed
Mar 27, 2022
MondaySHB
left a comment
MondaySHB
left a comment
There was a problem hiding this comment.
어려웠다고 말씀하신 것에 비해 정말 잘 구현 주시고 빨리 끝내주셨네요!!
commit 할 때 간략한 내용을 메시지를 서술해주시면 더 좋을 것 같습니다.
| float m_Timer; | ||
| bool m_HasAudioPlayed; | ||
|
|
||
| void OnTriggerEnter(Collider other) |
There was a problem hiding this comment.
C#의 특징 중 하나가 Event에 대한 반응(callback) 함수들이라 생각하는데 이 부분도 잘 구현해주셨습니다!!
| m_Rotation = Quaternion.LookRotation(desiredForward); | ||
| } | ||
|
|
||
| void OnAnimatorMove() |
There was a problem hiding this comment.
함수에 상당히 영어가 많고, 생소하신 부분이 있으셨을 거 같은데 https://docs.unity3d.com/kr/530/ScriptReference/AccelerationEvent.html와 같은 문서 페이지 참조하시면 한글로 api를 볼 수 있습니다~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-과제하면서 느낀 점: 유니티로 직접 간단한 게임을 제작할 수 있어 재밌었습니다! 처음에는 전부 영어이기도 해서 어려웠는데, 게임이 만들어지는 걸 보며 흥미가 느껴졌습니다.
-과제하면서 어려웠던 부분: C#이 처음이라 약간 생소했는데, 튜토리얼로 계속 공부해보며 익숙해진 것 같습니다.
-개발 그룹 운영진에게 이야기하고 싶은 부분: 따로 없습니다!