Skip to content

chore(docker): switch default Python to 3.11 and add time/node tooling#79

Merged
Makiras merged 2 commits into
masterfrom
fix_docker
Apr 21, 2026
Merged

chore(docker): switch default Python to 3.11 and add time/node tooling#79
Makiras merged 2 commits into
masterfrom
fix_docker

Conversation

@SFangYy
Copy link
Copy Markdown
Contributor

@SFangYy SFangYy commented Mar 26, 2026

Description

This PR updates the Docker image to use Python 3.11 as the default Python runtime and adds missing tooling for development workflows.

  • remove legacy python3, python3-pip, and python3-dev base packages
  • install python3.11, python3.11-dev, and python3.11-venv
  • bootstrap pip for Python 3.11 and set python3/pip3 alternatives to 3.11
  • add Node.js 20 and upgrade npm
  • add time package to base dependencies

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

docker run -it --rm --name picker ghcr.io/xs-mlvp/picker:latest

Checklist:

  • My code follows the style guidelines of this project
  • I have added the appropriate labels
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copilot AI review requested due to automatic review settings March 26, 2026 03:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the development Docker image to make Python 3.11 the default Python runtime, while also adding missing base tooling (including Node.js 20 and time) to support common workflows.

Changes:

  • Install Python 3.11 (+ dev/venv) and bootstrap pip for it; attempt to make python3/pip3 point to 3.11.
  • Add Node.js 20 (via NodeSource) and upgrade npm to v10.
  • Add the time package to base dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Dockerfile
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
yaozhicheng
yaozhicheng previously approved these changes Mar 26, 2026
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
@Makiras Makiras merged commit b09ad52 into master Apr 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants