Closed
Conversation
Author
|
Fixes #767 |
jasonmay
force-pushed
the
replace-whitespace
branch
2 times, most recently
from
bf20d4d to
153bc52
Compare
jasonmay
force-pushed
the
replace-whitespace
branch
from
153bc52 to
24c3a35
Compare
Author
|
@JugglerShu is there anything you'd like added in order to make this worthy of merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took @J-Fields and addressed some issues in the PR in #770.
@structAnkit - I discovered
jdidn't work because it was injecting\rand\r\nmakes XVim very confused. I modified it so it never injects\ranyway. Just\nwhich is the XVim convention. This solves 1 and 2 of your concern. Also, auto-indent works with a trick to do "interpret key events" against the source view.@JugglerShu - test cases are added. hopefully this is good enough to merge now!