Add Range Display to Mega Torch and Dread Lamp

[Syer10]

GUI

Inside Range

Outside Range

Notes

• There is some z-fighting when blocks merge
• Its enabled per-mega torch server-wide, so everyone can see the range display when enabled
• It works with shaders (Tested with Iris)

[Xalcon]

Thank you for this PR.

I have a very basic client-side-only implementation in 1.20, but i was never super happy with how it works, especially when multiple torches overlap.

I dont have much time during the week, I'll take a closer look on the weekend - but I'm unsure what you mean its server wide. Each player still has to explicitly enable it in the settings - but it will show all torches? Or will you need to toggle it per torch?

Either way, I'll try to find some time this weekend to review this.

[Syer10]

Each Torch now has a GUI that enables the range preview, the range preview is then shown to all players since it's a part of the Torch itself, and not the client.

[mnfu]

Each Torch now has a GUI that enables the range preview, the range preview is then shown to all players since it's a part of the Torch itself, and not the client.

Just my two cents as someone with no stake in this: this feels more like a client-side visualization feature (similar to light overlay mods), so it might make more sense as a per-player toggle rather than being visible to everyone. Having it global could be intrusive depending on server use.

[Xalcon]

Each Torch now has a GUI that enables the range preview, the range preview is then shown to all players since it's a part of the Torch itself, and not the client.

Just my two cents as someone with no stake in this: this feels more like a client-side visualization feature (similar to light overlay mods), so it might make more sense as a per-player toggle rather than being visible to everyone. Having it global could be intrusive depending on server use.

Your concerns are valid and thats how I implemented it in the 1.20 version, fully clientside - but just to make sure, this PR doesnt automatically render the box for all players on a server. Each player needs to enable the volume rendering first in the settings and then it will show. The only thing that is server side, is which volumes are displayed when a player enables the rendering.

Its one of the reasons why I've not merged it yet. I'm not sure if I like it. Its not necessarily bad, but I want to avoid unnecessary synchronization between server and client for a client-side only feature. Since I have bigger plans for mc v26+, I think I'll simply merge this as is, just to get the feature in and redesign torchmaster from scratch. A lot of design decisions in the core of torchmaster limit capabilities I wanted to implement for ages now.

I need to think about this for a bit longer. I didnt find time on the weekend, but I do have a day off on thursday, so thats when you can expect to see some movement in this feature.