This repository was archived by the owner on Aug 12, 2018. It is now read-only.
Added MinGW makefile (works on appveyor).#229
Open
dejbug wants to merge 2 commits intoXhmikosR:masterfrom
Open
Added MinGW makefile (works on appveyor).#229dejbug wants to merge 2 commits intoXhmikosR:masterfrom
dejbug wants to merge 2 commits intoXhmikosR:masterfrom
Conversation
The code needs a few (minor) fixes for things which give the more pedantic GCC some trouble. - possible uses of uninitialized variables - signed-unsigned comparisons - missing fields in initializers - missing casts - missing braces - 'escapes' at EOLs (in comments) - a nested comment
Contributor
|
Maybe I could use your makefile, see zufuliu/notepad4#2 and https://github.com/zufuliu/notepad2/wiki/Build-Notepad2#gcc |
Author
|
I see. I'll fix this soon. 👍 |
Author
|
@zufuliu of course! 😄 You should delete the inline overrides (lines 69-77) though. It's rubbish; a carry-over from my initial fiddlings and I just saw that the variables are wrong. |
Contributor
|
@dejbug #202 and zufuliu/notepad4#10 and zufuliu/notepad4@547d1c3 and https://github.com/zufuliu/notepad2/blob/master/src/Edit.c#L3613 might help you to fix GCC build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was going to add a minor feature (a setting to disable filevars except for explicitly enabled ones, i.e. with "enable-local-variables=1"), to do that I had first to be able to compile the project on my machine (old winxp box). I wanted to do the whole CMake thing, but writing a makefile was for me the quickest approach. I had to rewrite version.sh into a python script (and to make it work on appveyor, I had to fix some of its logic).
This is my first pull request ever. Please bear with me 😸 !