implement head and tail commands in command line shell#215
Merged
AlixANNERAUD merged 3 commits intomainfrom Apr 7, 2026
Merged
implement head and tail commands in command line shell#215AlixANNERAUD merged 3 commits intomainfrom
AlixANNERAUD merged 3 commits intomainfrom
Conversation
438057b to
471dd56
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the
headandtailcommands to the shell, allowing users to view the first or last N lines of a file, similar to their Unix counterparts. It introduces new command implementations, integrates them into the command resolution and dispatch system, and provides comprehensive tests for both commands. Additionally, there is a small fix in the argument parsing macro to improve positional argument handling.New command implementations:
HeadCommandandTailCommandinhead.rsandtail.rs, with logic to read the first or last N lines of a file, including robust handling of edge cases (e.g., files without trailing newlines, zero lines requested). Both commands support-n/--linesoption for specifying the number of lines. [1] [2]Command system integration:
UserCommandKindenum, and extended the command resolution and dispatch logic to supportheadandtail. [1] [2] [3] [4] [5]headandtailby name.Testing and robustness:
headandtaillogic, covering various cases such as files with/without trailing newlines, zero lines requested, and argument parsing. [1] [2]--show-keyboardflag is handled correctly.Macro improvement:
.next_positional()with.value()for better error handling and correctness when extracting positional arguments.