Skip to content

Master branch fixes for system timeline#66

Merged
jvillarre merged 1 commit into
Xilinx:masterfrom
predutta:sys_timeline
May 15, 2026
Merged

Master branch fixes for system timeline#66
jvillarre merged 1 commit into
Xilinx:masterfrom
predutta:sys_timeline

Conversation

@predutta
Copy link
Copy Markdown
Collaborator

Issues fixed: This change addresses two problems in the AIE system–timeline path. First, if system_timeline is opted for multi-partition designs it gave Segmentation fault. Second, the timestamp binary could end up empty and give incorrect timeline_trace.

The Solution: For the first issue, fix is to return immediately after setting AIEData.valid = false in that catch so we never run the rest of the update on bad state. Also, System timeline is turned on only when the INI flag is set and the app style is load-xclbin and the design is not treated as multi-partition. For the second issue, the fix is to call moveAIETimerSamples() before opening the file and return without truncating when there are no samples left to emit.

CR's fixed:
[CR-1267713]: System Timeline AIE trace timestamps not synchronized with PL/host trace — AIE events appear ~97 seconds offset from PL kernel events
[CR-1266585]: AIE Independent partition event trace designs failing with segmentation fault on the board.

The fix has been tested on a vck190 design that was giving incorrect timeline_trace before and a VEK280 aie independent partition design.

Signed-off-by: predutta <predutta@amd.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes two reliability issues in the AIE system-timeline path: (1) a multi-partition design crash by preventing continued execution after a failed trace initialization, and (2) generation of an empty/incorrect aie_event_timestamps.bin by avoiding a second truncating write when there are no remaining timer samples.

Changes:

  • Prevents continuing updateAIEDevice() after a failed initReadTraces() (avoids operating on invalid state).
  • Gates “system timeline” enablement to enable_system_timeline && LOAD_XCLBIN_STYLE && !multipartition.
  • Writes timestamp binary only when timer samples exist (moves samples before opening the file; skips truncation when empty).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
profile/writer/aie_trace/aie_trace_timestamps_writer.cpp Avoids truncating the timestamps binary on a subsequent write when no samples remain.
profile/plugin/aie_trace/aie_trace_plugin.h Initializes the polling control atomic to a known value (false).
profile/plugin/aie_trace/aie_trace_plugin.cpp Early-return on init failure; restrict system timeline to supported app style / partitioning.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jvillarre jvillarre merged commit 39cfd5f into Xilinx:master May 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants