Master branch fixes for system timeline#66
Merged
Conversation
Signed-off-by: predutta <predutta@amd.com>
There was a problem hiding this comment.
Pull request overview
Fixes two reliability issues in the AIE system-timeline path: (1) a multi-partition design crash by preventing continued execution after a failed trace initialization, and (2) generation of an empty/incorrect aie_event_timestamps.bin by avoiding a second truncating write when there are no remaining timer samples.
Changes:
- Prevents continuing
updateAIEDevice()after a failedinitReadTraces()(avoids operating on invalid state). - Gates “system timeline” enablement to
enable_system_timeline && LOAD_XCLBIN_STYLE && !multipartition. - Writes timestamp binary only when timer samples exist (moves samples before opening the file; skips truncation when empty).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
profile/writer/aie_trace/aie_trace_timestamps_writer.cpp |
Avoids truncating the timestamps binary on a subsequent write when no samples remain. |
profile/plugin/aie_trace/aie_trace_plugin.h |
Initializes the polling control atomic to a known value (false). |
profile/plugin/aie_trace/aie_trace_plugin.cpp |
Early-return on init failure; restrict system timeline to supported app style / partitioning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jvillarre
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues fixed: This change addresses two problems in the AIE system–timeline path. First, if system_timeline is opted for multi-partition designs it gave Segmentation fault. Second, the timestamp binary could end up empty and give incorrect timeline_trace.
The Solution: For the first issue, fix is to return immediately after setting AIEData.valid = false in that catch so we never run the rest of the update on bad state. Also, System timeline is turned on only when the INI flag is set and the app style is load-xclbin and the design is not treated as multi-partition. For the second issue, the fix is to call moveAIETimerSamples() before opening the file and return without truncating when there are no samples left to emit.
CR's fixed:
[CR-1267713]: System Timeline AIE trace timestamps not synchronized with PL/host trace — AIE events appear ~97 seconds offset from PL kernel events
[CR-1266585]: AIE Independent partition event trace designs failing with segmentation fault on the board.
The fix has been tested on a vck190 design that was giving incorrect timeline_trace before and a VEK280 aie independent partition design.