Create CMake snippet for finding protobuf#9646
Merged
Merged
Conversation
Redo Xilinx#9633 to (1) refactor messy code to find protobuf in config or module node, (2) work with Yocto builds. This simplifies xbtracer CMakeLists.txt removing the logic behind finding protobuf. Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
stsoe
requested review from
AShivangi,
chvamshi-xilinx and
rozumx
as code owners
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
I can confirm that protobuf is found and |
Collaborator
Author
Thanks much for confirming. I will try your vcpkg PR next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Redo #9633 to (1) refactor messy code to find protobuf in config or module node, (2) work with Yocto builds.
This simplifies xbtracer CMakeLists.txt removing the logic behind finding protobuf.