fix(backoff): fibonacci delay should cap on max delay#232
Open
dentiny wants to merge 1 commit intoXuanwo:mainfrom
Open
fix(backoff): fibonacci delay should cap on max delay#232dentiny wants to merge 1 commit intoXuanwo:mainfrom
dentiny wants to merge 1 commit intoXuanwo:mainfrom
Conversation
b88a255 to
0e8291b
Compare
Author
error: creating a new box
--> backon-macros/src/lib.rs:100:9
|
100 | item_fn.block = Box::new(block);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace existing content with inner value instead: `*item_fn.block = block`
|
= note: this creates a needless allocation
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#replace_box
= note: `-D clippy::replace-box` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::replaThe failed CI doesn't seem to be related to my change |
Author
|
Nightly unit failure also seems unrelated EXPECTED:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error: `adjust` is only available for async functions
--> tests/cases/fail_adjust_blocking.rs:8:4
|
8 | fn invalid_blocking() -> Result<(), &'static str> {
| ^^^^^^^^^^^^^^^^
error[E0425]: cannot find function `invalid_blocking` in this scope
--> tests/cases/fail_adjust_blocking.rs:13:13
|
13 | let _ = invalid_blocking();
| ^^^^^^^^^^^^^^^^ not found in this scope
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
ACTUAL OUTPUT:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error: `adjust` is only available for async functions
--> tests/cases/fail_adjust_blocking.rs:8:4
|
8 | fn invalid_blocking() -> Result<(), &'static str> {
| ^^^^^^^^^^^^^^^^
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
note: If the actual output is the correct output you can bless it by rerunning
your test with the environment variable TRYBUILD=overwrite
test tests/cases/fail_context_ident.rs [should fail to compile] ... ok
test tests/cases/fail_method_self_context.rs [should fail to compile] ... ok
test tests/cases/fail_method_mut_context.rs [should fail to compile] ... ok
test tests/cases/fail_context_value_self.rs [should fail to compile] ... ok
test trybuild_suite ... FAILED
failures:
---- trybuild_suite stdout ---- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #231