Skip to content

[YS-589] feature: 공고 목록 조회 시 응답값에 timeRequired(소요시간), count(횟수) 컬럼 추가 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chock-cho merged 3 commits into from
Dec 14, 2025
Merged

[YS-589] feature: 공고 목록 조회 시 응답값에 timeRequired(소요시간), count(횟수) 컬럼 추가 #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e71a4d
feature: add timeRequired, count field to ExperimentPost responses
chock-cho Dec 14, 2025
97b91be
fix: add fixture to non-import classes
chock-cho Dec 14, 2025
1d24052
fix: fix compile errors
chock-cho Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions application/src/main/kotlin/com/dobby/usecase/experiment/CreateExperimentPostUseCase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ class CreateExperimentPostUseCase(
val postId: String,
val title: String,
val views: Int,
val timeRequired: TimeSlot?,
val count: Int?,
val isOnCampus: Boolean,
val place: String?,
val reward: String?,
Expand Down Expand Up @@ -143,6 +145,8 @@ class CreateExperimentPostUseCase(
postId = savedExperimentPost.id,
title = savedExperimentPost.title,
views = savedExperimentPost.views,
timeRequired = savedExperimentPost.timeRequired,
count = savedExperimentPost.count,
isOnCampus = savedExperimentPost.isOnCampus,
place = savedExperimentPost.place,
durationInfo = DurationInfo(
Expand Down
5 changes: 5 additions & 0 deletions application/src/main/kotlin/com/dobby/usecase/experiment/GetExperimentPostsUseCase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import com.dobby.enums.MatchType
import com.dobby.enums.areaInfo.Area
import com.dobby.enums.areaInfo.Region
import com.dobby.enums.experiment.RecruitStatus
import com.dobby.enums.experiment.TimeSlot
import com.dobby.enums.member.GenderType
import com.dobby.gateway.experiment.ExperimentPostGateway
import com.dobby.model.experiment.CustomFilter
Expand Down Expand Up @@ -51,6 +52,8 @@ class GetExperimentPostsUseCase(
val experimentPostId: String,
val title: String,
val views: Int,
val count: Int?,
val timeRequired: TimeSlot?,
val isOnCampus: Boolean,
val place: String?,
val reward: String,
Expand Down Expand Up @@ -83,6 +86,8 @@ class GetExperimentPostsUseCase(
experimentPostId = post.id,
title = post.title,
views = post.views,
count = post.count,
timeRequired = post.timeRequired,
isOnCampus = post.isOnCampus,
place = post.place,
reward = post.reward,
Expand Down
4 changes: 4 additions & 0 deletions application/src/main/kotlin/com/dobby/usecase/experiment/UpdateExperimentPostUseCase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ class UpdateExperimentPostUseCase(
val postId: String,
val title: String,
val views: Int,
val timeRequired: TimeSlot?,
val count: Int?,
val isOnCampus: Boolean,
val place: String?,
val reward: String?,
Expand Down Expand Up @@ -125,6 +127,8 @@ class UpdateExperimentPostUseCase(
postId = updatedPost.id,
title = updatedPost.title,
views = updatedPost.views,
timeRequired = updatedPost.timeRequired,
count = updatedPost.count,
isOnCampus = updatedPost.isOnCampus,
place = updatedPost.place,
reward = updatedPost.reward,
Expand Down
2 changes: 2 additions & 0 deletions application/src/test/kotlin/com/dobby/usecase/experiment/GetExperimentPostsUseCaseTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ class GetExperimentPostsUseCaseTest : BehaviorSpec({
result.first().postInfo.title shouldBe "야뿌 피자 먹방 테스트"
result.first().postInfo.place shouldBe "야뿌 대학교"
result.first().postInfo.reward shouldBe "스타벅스 1만원권 쿠폰"
result.first().postInfo.timeRequired shouldBe TimeSlot.ABOUT_1H
result.first().postInfo.count shouldBe 10
result.first().postInfo.recruitStatus shouldBe false
}
}
Expand Down
4 changes: 3 additions & 1 deletion presentation/src/main/kotlin/com/dobby/api/dto/response/experiment/PostInfo.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
package com.dobby.api.dto.response.experiment

import com.dobby.enums.experiment.TimeSlot
import java.time.LocalDate
Comment on lines +2 to 3
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

ktlint 실패(Import 그룹 사이 빈 줄/정렬)로 CI가 깨집니다 — 즉시 수정 필요
현재 import 사이 빈 줄 때문에 ktlint-code-quality-check가 실패합니다.

 import com.dobby.enums.experiment.TimeSlot
-
 import java.time.LocalDate
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
import com.dobby.enums.experiment.TimeSlot
import java.time.LocalDate
import com.dobby.enums.experiment.TimeSlot
import java.time.LocalDate
🧰 Tools
🪛 GitHub Actions: ktlint-code-quality-check

[error] 2-2: KtLint: Imports must be ordered lexicographically and without empty lines between groups.

🤖 Prompt for AI Agents 
In
presentation/src/main/kotlin/com/dobby/api/dto/response/experiment/PostInfo.kt
around lines 2 to 4, ktlint is failing because import groups are separated by an
extra blank line and/or misordered; remove the blank line between the imports
and ensure imports are sorted/ grouped according to project ktlint rules
(standard Kotlin stdlib/java imports first, then project imports) so that the
two imports appear contiguous and properly ordered without extra empty lines.

data class PostInfo(
val experimentPostId: String,
val title: String,
val views: Int,
val timeRequired: TimeSlot?,
val count: Int?,
val isOnCampus: Boolean,
val place: String?,
val reward: String?,
Expand Down
6 changes: 6 additions & 0 deletions presentation/src/main/kotlin/com/dobby/api/mapper/ExperimentPostMapper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ object ExperimentPostMapper {
experimentPostId = input.postId,
title = input.title,
views = input.views,
timeRequired = input.timeRequired,
count = input.count,
isOnCampus = input.isOnCampus,
durationInfo = DurationInfo(
startDate = input.durationInfo?.startDate,
Expand Down Expand Up @@ -142,6 +144,8 @@ object ExperimentPostMapper {
experimentPostId = input.postId,
title = input.title,
views = input.views,
timeRequired = input.timeRequired,
count = input.count,
durationInfo = DurationInfo(
startDate = input.durationInfo?.startDate,
endDate = input.durationInfo?.endDate
Expand Down Expand Up @@ -405,6 +409,8 @@ object ExperimentPostMapper {
experimentPostId = post.postInfo.experimentPostId,
title = post.postInfo.title,
views = post.postInfo.views,
count = post.postInfo.count,
timeRequired = post.postInfo.timeRequired,
isOnCampus = post.postInfo.isOnCampus,
place = post.postInfo.place,
reward = post.postInfo.reward,
Expand Down
Loading