Open
Conversation
- Resolved app.json: kept both usesCleartextTraffic and iOS NSAppTransportSecurity - Resolved FileContextPills: kept onPress prop addition for chip interactions - Accepted upstream changes for connections.tsx and [id].tsx
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
- Created Expo config plugin to inject network security config - Enables cleartext HTTP traffic for local development - Adds usesCleartextTraffic and networkSecurityConfig to AndroidManifest - Allows connections to local IP ranges (192.168.x.x, 10.x.x.x, 172.16.x.x) - Required for GitHub Actions APK builds to connect to opencode server Fixes WiFi connection issues on physical Android devices
- Replaced custom config plugin with official expo-build-properties - Removed unnecessary @expo/config-plugins dependency - Added expo-build-properties with usesCleartextTraffic: true - This is the official Expo-recommended approach for Android 9+ HTTP support - Fixes WiFi connectivity issues on physical Android devices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes configuration changes to the mobile app's platform settings and a minor enhancement to the
FileContextPillscomponent to support press actions on individual file pills. The most important changes are grouped below.Mobile App Platform Configuration:
usesCleartextTraffic: trueto the app's Android manifest configuration.infoPlistto allow arbitrary loads and local networking by settingNSAllowsArbitraryLoads: trueandNSAllowsLocalNetworking: trueunderNSAppTransportSecurity.Component Enhancement:
FileContextPillscomponent: Added an optionalonPressprop to handle press events on individual file pills, and updated the component to call this handler when a pill is pressed. [1] [2]