Skip to content

fix: generate the TOTP QR internally #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YasharF wants to merge 1 commit into
base: master
Choose a base branch
from
+459 −195
Open

fix: generate the TOTP QR internally #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion controllers/user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ const passport = require('passport');
const validator = require('validator');
const mailChecker = require('mailchecker');
const OTPAuth = require('otpauth');
const encodeQR = require('qr').default;
const User = require('../models/User');
const Session = require('../models/Session');
const nodemailerConfig = require('../config/nodemailer');
Expand Down Expand Up @@ -970,9 +971,12 @@ exports.getTotpSetup = async (req, res, next) => {
secret,
});
req.session.totpSecret = secret.base32;
// Generate QR image (SVG) data URI using the `qr` package
const svg = encodeQR(totp.toString(), 'svg');
const qrImage = `data:image/svg+xml;utf8,${encodeURIComponent(svg)}`;
Comment thread
YasharF marked this conversation as resolved.
res.render('account/totp-setup', {
title: 'Setup Authenticator',
qrCode: totp.toString(),
qrImage,
secret: secret.base32,
});
} catch (err) {
Expand Down
Loading
Loading