Skip to content

YH-1562: add skeleton for resource request creation page#1222

Open
PavelSummer2611 wants to merge 3 commits into
developfrom
feature/YH-1562
Open

YH-1562: add skeleton for resource request creation page#1222
PavelSummer2611 wants to merge 3 commits into
developfrom
feature/YH-1562

Conversation

@PavelSummer2611

Copy link
Copy Markdown
Collaborator

Добавлен скелетон страницы создания заявки ресурса.

@PavelSummer2611 PavelSummer2611 added feature New functionality or improvements review the task is currently being reviewed labels May 4, 2026

import styles from './ResourceForm.module.css';

export const ResourceFormSkeleton = () => {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ISSUE] - В компоненте ResourceForm в первых двух полях нужно внести изменения, чтобы был единый вид

Было

<Flex direction="column" gap="8" className={styles['form-field']}>
				<Text variant="body4" color="black-800">
					{t(Marketplace.NAME_SHORT)}
				</Text>
				<div className={styles.form}>
					<FormControl name="name" control={control} label={t(Marketplace.NAME_LABEL)}>
						{(field, hasError) => (
							<TextArea
								{...field}
								state={hasError ? 'error' : 'default'}
								className={styles.name}
								placeholder={t(Marketplace.NAME_LABEL)}
								disabled={readonly}
							/>
						)}
					</FormControl>
				</div>
			</Flex>

Стало

<FormField
	label={t(Marketplace.DESCRIPTION_SHORT)}
	direction="column"
	description={t(Marketplace.DESCRIPTION_LABEL)}
>
	<div className={styles.form}>
		<FormControl name="description" control={control}>
			{(field, hasError) => (
				<TextArea
					{...field}
					state={hasError ? 'error' : 'default'}
					className={styles.name}
					placeholder={t(Marketplace.DESCRIPTION_LABEL)}
					disabled={readonly}
				/>
			)}
		</FormControl>
	</div>
</FormField>

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил

export const ResourceFormSkeleton = () => {
return (
<Flex direction="column" gap="60" className={styles.wrapper}>
<Flex direction="column" gap="8" className={styles['form-field']}>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ISSUE] - После исправления комментария выше надо будет в этом скелетоне везде заменить

<Flex direction="column" gap="8" className={styles['form-field']}>
	<TextSkeleton variant="body4" width={110} />
	<TextSkeleton variant="body2" width={150} />
	компонент с инпутом
</Flex>

На

<FormFieldSkeleton>
  компонент с инпутом
</FormFieldSkeleton>

Скелетон FormFieldSkeleton надо будет тебе создать

@PavelSummer2611 PavelSummer2611 May 13, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил, FormFieldSkeleton уже был, добавил в него direction

<ButtonSkeleton size="large" width={210} className={styles['submit-button']} />
</Flex>

<Card className={styles.content}>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SUGGESTION] - CardSkeleton

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил

@@ -1 +1,2 @@
export { ResourceRequestCreateForm } from './ui/ResourceRequestCreateForm/ResourceRequestCreateForm';
export { ResourceRequestFormWithHeaderSkeleton } from './ui/ResourceRequestCreateFormWithHeader/ResourceRequestFormWithHeader.skeleton';

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SUGGESTION] - Создай дополнительно ResourceRequestCreateFormSkeleton в котором будет ResourceRequestFormWithHeaderSkeleton. И экспортируй уже ResourceRequestCreateFormSkeleton

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сделано

@PerelomaDenis PerelomaDenis added comments Code improvements are required and removed review the task is currently being reviewed labels May 8, 2026
@PavelSummer2611 PavelSummer2611 added review the task is currently being reviewed and removed comments Code improvements are required labels May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New functionality or improvements review the task is currently being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants