-
Notifications
You must be signed in to change notification settings - Fork 11
Feature/yh 1915 #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
artem-Tolmachev
wants to merge
5
commits into
develop
Choose a base branch
from
feature/YH-1915
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/yh 1915 #1249
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a122523
YH-1915: added task sorting by name, difficulty, createdAt with ASC/D…
artem-Tolmachev 856d55b
YH-1915: added English translations for task sorting
artem-Tolmachev b0ec187
YH-1915: integrate sort parameters with API and refactor sorting logic
artem-Tolmachev 657e0bb
YH-1915: fixed review comments
artem-Tolmachev e4b1c5c
YH-1915: resolve merge conflict in QuestionsFilters
artem-Tolmachev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
src/features/task/filterTasks/ui/SortTasksByField/SortTasksByField.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import { useTranslation } from 'react-i18next'; | ||
|
|
||
| import { i18Namespace, Tasks } from '@/shared/config'; | ||
| import { BaseFilterItem, BaseFilterSection } from '@/shared/ui/BaseFilterSection'; | ||
|
|
||
| import { TaskFilterOrderBy } from '@/entities/task'; | ||
|
|
||
| interface SortTasksFieldProps { | ||
| selectedOrderBy?: TaskFilterOrderBy; | ||
| onChangeSortField: (field?: TaskFilterOrderBy) => void; | ||
| } | ||
|
|
||
| export const SortTasksByField = ({ onChangeSortField, selectedOrderBy }: SortTasksFieldProps) => { | ||
| const { t } = useTranslation(i18Namespace.task); | ||
|
|
||
| const field: BaseFilterItem<TaskFilterOrderBy>[] = [ | ||
| { id: 'name', title: t(Tasks.SORT_FIELDS_NAME) }, | ||
| { id: 'difficulty', title: t(Tasks.SORT_DIFFICULTY) }, | ||
| { id: 'createdAt', title: t(Tasks.SORT_CREATED_AT) }, | ||
| ]; | ||
|
|
||
| const preparedData = field.map((item) => ({ | ||
| ...item, | ||
| active: selectedOrderBy === item.id, | ||
| })); | ||
|
|
||
| const onChangeOrder = (orderBy: TaskFilterOrderBy) => { | ||
| onChangeSortField(orderBy === selectedOrderBy ? undefined : orderBy); | ||
| }; | ||
|
|
||
| return ( | ||
| <BaseFilterSection | ||
| title={t(Tasks.SORT_FIELDS_TITLE)} | ||
| data={preparedData} | ||
| onClick={onChangeOrder} | ||
| /> | ||
| ); | ||
| }; |
36 changes: 36 additions & 0 deletions
36
src/features/task/filterTasks/ui/SortTasksByOrder/SortTasksByOrder.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import { useTranslation } from 'react-i18next'; | ||
|
|
||
| import { i18Namespace, Tasks } from '@/shared/config'; | ||
| import { SortOrder } from '@/shared/libs'; | ||
| import { BaseFilterItem, BaseFilterSection } from '@/shared/ui/BaseFilterSection'; | ||
|
|
||
| interface SortTasksByOrderProps { | ||
| selectedOrder?: SortOrder; | ||
| onChangeSortOrder: (sortOrder?: SortOrder) => void; | ||
| } | ||
|
|
||
| export const SortTasksByOrder = ({ onChangeSortOrder, selectedOrder }: SortTasksByOrderProps) => { | ||
| const { t } = useTranslation(i18Namespace.task); | ||
|
|
||
| const order: BaseFilterItem<SortOrder>[] = [ | ||
| { id: 'ASC', title: t(Tasks.SORT_ASC) }, | ||
| { id: 'DESC', title: t(Tasks.SORT_DESC) }, | ||
| ]; | ||
|
|
||
| const preparedData = order.map((item) => ({ | ||
| ...item, | ||
| active: selectedOrder === item.id, | ||
| })); | ||
|
|
||
| const onChangeOrder = (orderBy: SortOrder) => { | ||
| onChangeSortOrder(orderBy === selectedOrder ? undefined : orderBy); | ||
| }; | ||
|
|
||
| return ( | ||
| <BaseFilterSection | ||
| title={t(Tasks.SORT_ORDER_TITLE)} | ||
| onClick={onChangeOrder} | ||
| data={preparedData} | ||
| /> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ISSUE] - Не добавлены фильтры новые в запрос
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Исправил