Skip to content

Feature/yh 2059#1280

Open
artem-Tolmachev wants to merge 6 commits into
developfrom
feature/YH-2059
Open

Feature/yh 2059#1280
artem-Tolmachev wants to merge 6 commits into
developfrom
feature/YH-2059

Conversation

@artem-Tolmachev

@artem-Tolmachev artem-Tolmachev commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Что сделано:

  • сделан скелетон ReferralLinkDetailPageContentSkeleton для страницы ReferralLinkDetailPage.

@artem-Tolmachev artem-Tolmachev added review the task is currently being reviewed feature New functionality or improvements labels Jun 4, 2026
PerelomaDenis
PerelomaDenis reviewed Jun 6, 2026
View reviewed changes
Comment thread ...lLink/ReferalLinkDetail/ui/ReferralLinkDetailPage/ReferralLinkDetailPageContent.skeleton.tsx Outdated
return (
<>
<BackHeaderSkeleton>
<Skeleton width={170} height={48} borderRadius="12px" />

@PerelomaDenis PerelomaDenis Jun 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ISSUE] - Тут должны быть DeleteReferralLinkButtonSkeleton и ButtonSkeleton вместо двух Skeleton

@artem-Tolmachev artem-Tolmachev Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил

Comment thread src/entities/referralLink/ui/ReferralLinkCard/ReferralLinkCard.skeleton.tsx Outdated

export const ReferralLinkCardSkeleton = () => {
return (
<Card className={styles.card} withOutsideShadow>

@PerelomaDenis PerelomaDenis Jun 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ISSUE] - Card -> CardSkeleton
У Flex gap 14
Skeleton -> TextSkeleton variant="body5-accent"
Skeleton -> TextSkeleton variant="body3-accent"

@artem-Tolmachev artem-Tolmachev Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил

Comment thread src/entities/referralLink/index.ts Outdated

export { referralLinksHandlers } from './api/__mocks__';
export { referralLinksMock } from './api/__mocks__/data';
export { ReferralLinkCardSkeleton } from './ui/ReferralLinkCard/ReferralLinkCard.skeleton';

@PerelomaDenis PerelomaDenis Jun 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SUGGESTION] - Передвинь этот импорт к импорту основного компонента

@artem-Tolmachev artem-Tolmachev Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил

Comment thread src/widgets/referralLink/ReferralLinkAdditionalInfo/ui/ReferralLinkAdditionalInfo.skeleton.tsx Outdated

export const ReferralLinkAdditionalInfoSkeleton = () => {
return (
<Card className={styles.card} withOutsideShadow>

@PerelomaDenis PerelomaDenis Jun 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ISSUE] - Card -> CardSkeleton

@artem-Tolmachev artem-Tolmachev Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил

Comment thread src/widgets/referralLink/ReferralLinkAdditionalInfo/ui/ReferralLinkAdditionalInfo.skeleton.tsx Outdated
<Card className={styles.card} withOutsideShadow>
<Flex direction="column" gap="24">
<Flex direction="column" gap="16">
<Skeleton width={60} height={10} borderRadius="4px" />

@PerelomaDenis PerelomaDenis Jun 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ISSUE] - Под все компоненты свои скелетоны
ReferralLinkSumSkeleton
ReferralLinkCountSkeleton
ReferralLinkDateSkeleton
ReferralLinkDateSkeleton
ReferralLinkOwnerSkeleton

И в каждом никаких Skeleton не должно быть. Внутри каждого есть компоненты под которые нужно использовать свои скелетоны

@artem-Tolmachev artem-Tolmachev Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправил

@PerelomaDenis PerelomaDenis added comments Code improvements are required and removed review the task is currently being reviewed labels Jun 6, 2026
@artem-Tolmachev artem-Tolmachev added review the task is currently being reviewed and removed comments Code improvements are required labels Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerelomaDenis PerelomaDenis PerelomaDenis left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

feature New functionality or improvements review the task is currently being reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artem-Tolmachev @PerelomaDenis