Skip to content

YH-2023: added feature flag for open/close NY-modal #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SmaginaOksana wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

YH-2023: added feature flag for open/close NY-modal #1284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f30ac4
YH-2023: added feature flag for open/close NY-modal
SmaginaOksana Jun 8, 2026
14a7b6d
YH-2023: changes from develop
SmaginaOksana Jun 18, 2026
1f105ca
Merge branch 'develop' into feature/YH-2023
SmaginaOksana Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/layouts/MainLayout/MainLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
if (isOpenSidebarDrawer) {
setIsOpenSidebarDrawer(false);
}
}, [location]);

Check warning on line 67 in src/app/layouts/MainLayout/MainLayout.tsx

View workflow job for this annotation

GitHub Actions / pr-checks 

React Hook useEffect has a missing dependency: 'isOpenSidebarDrawer'. Either include it or remove the dependency array

useEffect(() => {
if (isSpecializationEmpty && profilesCount === 1) {
Expand Down Expand Up @@ -98,14 +98,14 @@
<main className={styles.main}>
<div className={styles.container}>
<WithFeature featureId="nyBanner">
<NYBanner isOpenBanner={!isOpenNYBanner} lsKey={LS_BANNER_NY_DASHBOARD_KEY} />

Check warning on line 101 in src/app/layouts/MainLayout/MainLayout.tsx

View workflow job for this annotation

GitHub Actions / pr-checks 

Expected the depth of nested jsx elements to be <= 5, but found 7
</WithFeature>
<WithFeature featureId="nyModal">
<WithFeature featureId="dashboard.subscription.show-ny-modal">
<NYModal isOpenModal={!isOpenNYModal} />

Check warning on line 104 in src/app/layouts/MainLayout/MainLayout.tsx

View workflow job for this annotation

GitHub Actions / pr-checks 

Expected the depth of nested jsx elements to be <= 5, but found 7
</WithFeature>
<Breadcrumbs />

Check warning on line 106 in src/app/layouts/MainLayout/MainLayout.tsx

View workflow job for this annotation

GitHub Actions / pr-checks 

Expected the depth of nested jsx elements to be <= 5, but found 6
<Suspense fallback={<SkeletonGenerator />}>
<Outlet />

Check warning on line 108 in src/app/layouts/MainLayout/MainLayout.tsx

View workflow job for this annotation

GitHub Actions / pr-checks 

Expected the depth of nested jsx elements to be <= 5, but found 7
</Suspense>
</div>
</main>
Expand Down
10 changes: 5 additions & 5 deletions src/entities/featureFlag/api/__mocks__/data/featureFlagsMock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ export const featureFlagsMock: Response<FeatureFlagApiItem[]> = {
updatedAt: '2025-12-01T00:00:00.000Z',
},
{
id: 'nyModal',
flag: 'Новогодняя модалка',
id: '95268ab0-3ea7-43a0-b67c-66a621794220',
flag: 'dashboard.subscription.show-ny-modal',
enabled: false,
description: 'Попап-акция в начале года',
description: 'Фича флаг для показа новогоднего модального окна',
roles: ['admin'],
clientType: 'WEB',
createdAt: '2025-12-01T00:00:00.000Z',
updatedAt: '2025-12-01T00:00:00.000Z',
createdAt: '2026-06-08T10:28:12.296Z',
updatedAt: '2026-06-08T10:29:21.662Z',
},
{
id: '67003559-016b-4444-a1c4-9287dcfdfa50',
Expand Down
5 changes: 0 additions & 5 deletions src/entities/featureFlag/model/constants/featureFlags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ export const featureFlags: FeatureFlags = {
enabled: false,
description: 'Новогодний баннер со скидками на подписку',
},
nyModal: {
id: 'nyModal',
enabled: false,
description: 'Новогодняя модалка со скидками на подписку',
},
};

export const featureFlagApiUrls = {
Expand Down
2 changes: 1 addition & 1 deletion src/entities/featureFlag/model/types/featureFlag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { RoleName } from '@/entities/auth/@x/featureFlag';

export type FeatureFlagType =
| 'nyBanner'
| 'nyModal'
| 'dashboard.subscription.show-ny-modal'
| 'dashboard.analytic.user-rating'
| 'common.app.change-language'
| 'common.app.change-theme'
Expand Down
Loading