fix(telegram): convert WebP images to photos - #3454
Merged
Yeachan-Heo merged 2 commits intoJul 29, 2026
Merged
Conversation
Protected telegram-daemon image conversion requires a generation bump and byte-matching generation-guard digests for the WebP→photo path.
Yeachan-Heo
approved these changes
Jul 29, 2026
Yeachan-Heo
left a comment
Owner
There was a problem hiding this comment.
Exact-head adversarial re-review — APPROVE (MERGE_READY)
Reviewed head (exact): c8913a0cfde9a7c400b27109f80ca9903de6ed96
Prior red head: ce50885fad68d7522b0db4bbad08ca90491361b0
Base: post-#3453 1b5e2ad531bbc63d511a8fe2d1368c91205630ea (tip also advanced with unrelated #3272)
Hosted Dev CI: terminal success on exact repaired head (0 fail / 0 pending)
Mergeability: MERGEABLE / CLEAN
Author: @probepark (gate passed; maintainer_can_modify)
Mutation owner: single Telegram lifecycle lane (maintainer digest repair only)
Failure attribution (prior head)
| Check | Prior ce50885f |
Cause |
|---|---|---|
| Telegram daemon generation guard | failure | protected telegram-daemon.ts image-conversion path changed declaration digests without generation bump / manifest refresh (semantic manifest declaration digests do not byte-match the current tree) |
| Affected path validation / evidence producer / aggregate | failure | required generation-guard dependency red only |
| Task shards / native / Windows Telegram safety | success | product path itself was fine |
Maintainer repair (minimal closure)
On unique mutation ownership:
- Bumped
DAEMON_GENERATION33 → 34 with generation-34 prose (WebP/non-photo → photo conversion). - Refreshed suite pins for generation 34.
- Ran official
bun scripts/telegram-daemon-generation-guard.ts --write-manifest. - Verified:
--validate-current-tree✅- PR-mode guard vs
1b5e2ad5…✅ (required generation bump verified) - PR-mode guard vs current
origin/dev✅ bun test scripts/telegram-daemon-generation-guard.test.ts→ 41 pass / 0 failbun test packages/coding-agent/test/utils/image-resize.test.ts→ 10 pass / 0 fail
No product-logic rewrite beyond the required generation/digest closure.
Product re-check (still holds)
prepareTelegramImageAttachmentonly re-encodes non-photoimage/*frames; JPEG/PNG short-circuit; conversion failure falls back to prior document route.forceReencode+excludeWebPavoid WebP passthrough on the compact fast path.- Aspect/size gates keep Telegram photo constraints fail-closed.
supportsTelegramPhotoUploadexported from pure render mapper; allowlist remains JPEG/PNG.- No owner/incarnation/fencing contract soften observed.
Exact-head CI (repaired)
| Gate | Result |
|---|---|
Dev CI overall (c8913a0c) |
success |
| Telegram daemon generation guard | success |
| Windows Telegram daemon safety | success |
notifications-telegram-daemon.test.ts |
success |
utils/image-resize.test.ts |
success |
| Public site sync | success |
| Failed/pending required checks | 0 |
Verdict: APPROVE — MERGE_READY on c8913a0cfde9a7c400b27109f80ca9903de6ed96.
—
[repo owner's gaebal-gajae (clawdbot) 🦞]
Yeachan-Heo
pushed a commit
to gimso2x/gajae-code
that referenced
this pull request
Jul 29, 2026
Rebase topic-adoption Yeachan-Heo#3271 onto post-Yeachan-Heo#3454 tip. Protected daemon surface requires generation 35 (after WebP photo conversion at 34) with refreshed generation-guard digests.
7 tasks
Yeachan-Heo
added a commit
that referenced
this pull request
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
telegram_sendinto the same photo conversion pipelineFollow-up to #3453: that PR made WebP delivery reliable as a document; this PR upgrades valid WebP images to native Telegram photo messages.
Verification
bun test packages/coding-agent/test/notifications-telegram-daemon.test.ts --test-name-pattern "image_attachment converts WebP"bun test packages/coding-agent/test/utils/image-resize.test.tsbun test packages/coding-agent/test/notifications-threaded-render.test.ts packages/coding-agent/test/telegram-send-tool.test.ts packages/coding-agent/test/notifications-file-redaction.test.tsbun --cwd=packages/coding-agent run check