test(ai): repair exact dev evidence and timeout contract - #3457
Conversation
70d4fdf to
bf97b5d
Compare
bf97b5d to
beea559
Compare
Yeachan-Heo
left a comment
There was a problem hiding this comment.
Independent exact-head verdict: APPROVE — PR #3457 head beea55994c93461f82f7c3e80a74f4e336205d76, parent/current dev 0d13c7486cc7e9e47eeddc1a67ab9156a443384a.
The final independent architect/red-team pass is clear. It specifically re-tested the prior high-severity review concern by static adversarial analysis: the timed-out Codex websocket is closed only when its waiter expired with an empty queue; the next outer retry therefore creates a fresh socket, while late frames remain confined to the discarded connection. The regression is non-tautological: it emits a stale response from request 1 before the delayed fresh response from request 2, and would fail without the production close. It also pins typed stream_first_event_timeout, no provider-internal SSE replay, no websocket disablement/fallback-count increase, a fresh second socket, and fresh-only output.
Evidence integrity is exact: artifacts/architecture-2383-eval.json records Anthropic provider blob 8dace16954264312b4bb99e78236f868ea6c1b8d and SHA-256 7f521d452360fd79b07f6d8f0ba7ef75e531d2289d444fce37686b21a81577e9, matching the committed source and the repository-supported WRITE_ARCHITECTURE_2383_EVAL=1 regeneration path.
Terminal gates:
- Exact-head CI: 23 SUCCESS, 6 SKIPPED, 0 pending/failing; mergeability
clean. - Exact current-dev CI run
30417195980: terminal SUCCESS at0d13c7486. - Local repeated stale-frame regression: 25/25 pass.
- Focused repair net: 73/73 pass.
- Full
@gajae-code/aisuite on the exact rebased head under CI-equivalent neutral trusted env: 2009 pass / 337 skip / 0 fail across 232 files. packages/aiBiome + TypeScript check: pass.- Full workspace build, including native and compiled coding-agent binary: pass.
No unresolved finding remains. Exact head is safe to merge.
— GJC security/trust lane, independent architect/red-team review, 2026-07-29
Exact Dev CI repair
Repairs the two primary
@gajae-code/aifailures from Dev CI run 30414283071 at exact dev head0b1096861dea43ff18a4b1f8dcb0c4a05fd5780a. The evidence-producer and aggregate failures were downstream fail-closed cascades.1. Canonical Anthropic cache evidence
artifacts/architecture-2383-eval.jsoncarried source pins for bloba0acb862…, while exact dev's committedpackages/ai/src/providers/anthropic.tsis blob8dace169…. The mismatch already fails on pre-#3272 parent1b5e2ad5; #3272's first-parent diff touches only Azure provider/test/changelog files.Regenerated through the repository-supported path:
The resulting official pins are:
8dace16954264312b4bb99e78236f868ea6c1b8d7f521d452360fd79b07f6d8f0ba7ef75e531d2289d444fce37686b21a81577e9b1ca8d3183ca168140774f848ed414252178f7c5788d61243069862ae59c129bA non-writing rerun passes and an independent digest/blob check matches the committed provider bytes.
2. Deterministic Codex websocket first-event contract
The stale regression set removed
PI_CODEX_WEBSOCKET_FIRST_EVENT_TIMEOUT_MS; commitdd27b1b2intentionally removed that transport-specific variable and made first-event timeout a typed provider error for the outer retry/fallback layer. Consequently the test waited until Bun's unrelated 5000 ms test deadline.Bounded reproduction before repair:
1b5e2ad5: 10/10 timed out at ~5001 msThe test now supplies
streamFirstEventTimeoutMs: 10directly and pins the current safety contract: one websocket send, typedstream_first_event_timeout, no provider-internal SSE replay, and unchanged websocket session state. Post-repair stress: 25/25 pass in under one second. No timeout inflation and no production-code change.Verification on rebased head
70d4fdfe44cb02c0236b3dfb8387447bc0f8ddef@gajae-code/aisuite under CI-equivalent neutral trusted env: 2005 pass / 337 skip / 0 fail across 231 filesbun run --cwd packages/ai check: pass (Biome + TypeScript)bun run build: pass for all build-bearing workspaces, including native and compiled coding-agent binarygit diff --check: passA plain local full-suite run inherited this workstation's configured trusted provider endpoints and produced eight existing configuration-sensitive trust-test failures; the neutral trusted-env run above matches CI isolation and is the authoritative full-suite result.
No product source, secrets, workflow gates, or unrelated subsystem files are changed.