Added Consolaria and ThoriumMod compatibility.#1
Open
prankb0y wants to merge 1 commit into
Open
Conversation
Owner
|
Thank you for contributing to this mod.
I’m currently at work, so I can’t review the PR right away, but I’ll check
the code later today, merge it, and add you as a contributor.
Have a great weekend!
…---------- Forwarded message ---------
보낸사람: prankb0y ***@***.***>
Date: 2025년 12월 21일 (일) 오전 9:54
Subject: [Yeeyahou/BannerCollector] Added Consolaria and ThoriumMod
compatibility. (PR #1)
To: Yeeyahou/BannerCollector ***@***.***>
Cc: Subscribed ***@***.***>
I don't know a whole lot about coding, so i used AI to look over your code
& implement support for Thorium and Consolaria.
Consolaria was easy because there was only one banner tilesheet, like the
other mods, but Thorium used 20 banner tilesheets, so I had to do some
extra edits to make your code compatible with mods that use more than one
banner tilesheet. Additionally, Thorium's files were hidden, so I had to
use some debugging code to print a log of the banner name, itemid,
placestyle, tile type, and tile texture path. the debug code is turned off
right now, but I left it in to make it easier to add compatibility with
other mods. (124-279 in BannerUISystem.cs).
In my own testing this seems to work great! Let me know if you have any
questions or concerns. Would love to be able to support this mod.
------------------------------
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
- 2ef1fa9
<2ef1fa9>
Added Consolaria and ThoriumMod compatibility.
File Changes
(11 files <https://github.com/Yeeyahou/BannerCollector/pull/1/files>)
- *M* BannerLoad.cs
<https://github.com/Yeeyahou/BannerCollector/pull/1/files#diff-cc934ef7620b177e398e92a91cdf2bfb93af7a6a31a7f177528b23d26658f272>
(7)
- *M* BannerLoadMod.cs
<https://github.com/Yeeyahou/BannerCollector/pull/1/files#diff-edb306f905236e77ca48c82113f31912c3e8fd854ad74a3bb077d5fa23ba5aa6>
(1696)
- *M* BannerUI.cs
<https://github.com/Yeeyahou/BannerCollector/pull/1/files#diff-41d822fc5dfe365239affc8ecb558223235958e3f3d4d2dc2bf6378cf132ff09>
(3)
- *M* BannerUIElements.cs
<https://github.com/Yeeyahou/BannerCollector/pull/1/files#diff-8283c491d0692113618a1f521ffefcf12311836a6f52192810fc1b7e398db6ea>
(70)
- *M* BannerUISystem.cs
<https://github.com/Yeeyahou/BannerCollector/pull/1/files#diff-acd5ce2a0a8b42f886ecea0d9684070b8cbfbdba4c2c6bd12619f3f7c271d84d>
(205)
- *M* PlayerAssist.cs
<https://github.com/Yeeyahou/BannerCollector/pull/1/files#diff-cb4a54b227651785718f68e6fc8616b586dd95ffde38c8ce0ba3d682ee74bd02>
(11)
- *M* README.md
<https://github.com/Yeeyahou/BannerCollector/pull/1/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5>
(2)
- *M* Tiles/BannerBuffTile.cs
<https://github.com/Yeeyahou/BannerCollector/pull/1/files#diff-1a40a84eebbeacc25cb1734e2e47c3dd19a41b65137ff1ee616d844c429f324e>
(32)
- *M* build.txt
<https://github.com/Yeeyahou/BannerCollector/pull/1/files#diff-ded54ba0fd2fdc941903bb5f79b07f8f614dc6bfa40311cd4c40bf2b2bf578c4>
(2)
- *M* description.txt
<https://github.com/Yeeyahou/BannerCollector/pull/1/files#diff-463e739e1edc6756b70df0c3467038e4de55c76ae12786f00fe26649d9b6c37c>
(3)
- *M* description2.txt
<https://github.com/Yeeyahou/BannerCollector/pull/1/files#diff-4edf94d3d10b2117350c886155e568bf7df1bbd9fc33c8bd985a1f277019fff2>
(3)
Patch Links:
- https://github.com/Yeeyahou/BannerCollector/pull/1.patch
- https://github.com/Yeeyahou/BannerCollector/pull/1.diff
—
Reply to this email directly, view it on GitHub
<#1>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMLB53UPZGP3MWL6LVFMFOL4CXVTBAVCNFSM6AAAAACPUXFPTSVHI2DSMVQWIX3LMV43ASLTON2WKOZTG42TANJXGY4DSMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
--
이 메일은 지정된 수취인만을 위해 작성되었으며, 중요한 정보나 저작권을 포함하고 있을 수 있습니다. 어떠한 권한 없이, 본
문서에 포함된 정보의 전부 또는 일부를 무단으로 제3자에게 공개, 배포, 복사 또는 사용하는 것을 엄격히 금지합니다. 만약, 본 메일이
잘못 전송된 경우, 발신인 또는 당사에 알려주시고, 본 메일을 즉시 삭제하여 주시기 바랍니다.
This E-mail may
contain confidential information and/or copyright material. This email is
intended for the use of the addressee only. If you receive this email by
mistake, please either delete it without reproducing, distributing or
retaining copies thereof or notify the sender immediately.
<http://www.hansung.ac.kr/>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know a whole lot about coding, so i used AI to look over your code & implement support for Thorium and Consolaria.
Consolaria was easy because there was only one banner tilesheet, like the other mods, but Thorium used 20 banner tilesheets, so I had to do some extra edits to make your code compatible with mods that use more than one banner tilesheet. Additionally, Thorium's files were hidden, so I had to use some debugging code to print a log of the banner name, itemid, placestyle, tile type, and tile texture path. the debug code is turned off right now, but I left it in to make it easier to add compatibility with other mods. (124-279 in BannerUISystem.cs).
In my own testing this seems to work great! Let me know if you have any questions or concerns. Would love to be able to support this mod.