Open
Conversation
macisamuele
force-pushed
the
maci-polymorphism
branch
from
f64c42c to
eb252e7
Compare
… CodegenModel vars attributes
… before usage (to limit kotlin warnings)
The base codegen that we're using does not really keep all the properties in sync, which is not great, but other templates are already applying this type of fixes. Trying to create a PR would eventually not be beneficial since we're still based on swagger-codegen version 2 (while version 3 has been released)
… overridden properties (open and override modifiers)
macisamuele
force-pushed
the
maci-polymorphism
branch
from
eb252e7 to
b12f0b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103
The goal of this PR is to introduce support for polymorphic data models within the generated code.
Details of the feature introduced are properly described in the linked issue (so I'll avoid to repeat myself ;) )
WARNING: This PR is based on top of #104 ... that's why the long list of commits.
This is currently published to give visibility and a reason to some code additions of #104 justified as "check the subsequent branch".
The split of the changes in two PRs was mostly to reduce review complexity.