Remove const for escape_default and escape_unicode#1
Closed
ThijsRay wants to merge 1 commit intoYenForYang:patch-1from
Closed
Remove const for escape_default and escape_unicode#1ThijsRay wants to merge 1 commit intoYenForYang:patch-1from
ThijsRay wants to merge 1 commit intoYenForYang:patch-1from
Conversation
Author
|
@YenForYang Have you considered this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to use
to_ascii_lowercasein a const context, but was greeter by a surprising message thatto_ascii_lowercasewas not const. I saw that your pull request at rust-lang#79549 aims to fix this!I have opened this pull request, because I wanted to contribute to your PR at rust-lang#79549. I have removed the
constdeclarations fromescape_defaultandescape_unicodeto address the two comments on your PR.