This repository was archived by the owner on Oct 16, 2025. It is now read-only.
Fix failing splicing compute tests and get rid of various code smells#316
Open
Fix failing splicing compute tests and get rid of various code smells#316
Conversation
Shorten test suite time
…uring _filename_from_resource but can't use non-staticmethod methods on an uninstantiated class
…otting features to be documented as ipython notebooks and added to the tutorial
…ather than using boolean indexing
…ts and wrap around with col_wrap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the pandas update, some of the subsetting of dataframes got broken. This PR also removes a lot of commented out code that has been hanging around and shouldn't be
Check for code coverage. To run code coverage on only the file you changed,
for example
flotilla/compute/splicing.py, use this command:coverage run --source flotilla --omit=test --module py.test flotilla/test/compute/test_splicing.pywhich will show you which lines aren't covered by the tests.
numpydoc
style docstrings?
examples/, and is that notebook added todoc/tutorial.rst?.pyfilein
examples/?make lint.changes were made?