Draft
Conversation
…ncipal and yield withdrawals
… and facet tests in order to fetch the value of principal and yield from getPoolInfo and pendingRewards
Async strategy 1: Decentral RWA Pool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the Decentral async strategy integration and accompanying fork tests:
New DecentralStrategyFacet implementing async principal and yield withdrawals via Decentral
Handling of NFT position in Decentral vault
Comprehensive fork tests (DecentralStrategyFacet.base.fork.t.sol) covering:
** deposit → allocation → async principal withdrawal → approval → finalization → vault fulfillment
** yield accrual, request, approval, and finalization flows
** correct vault/share accounting and edge-case handling.
Tests are fork-based and use struct-based position decoding for correctness and debuggability.
This lays the groundwork for production-ready Decentral integration in async vaults.
Decentral pool implementation: https://basescan.org/address/0x177a4358e0b3ff55515ca67d2751ee4b78e1d0f3#code