Merged
Conversation
ksamarin90
commented
Sep 18, 2025
| * At unstake all sYLAY is burned. The maturing process of sYLAY restarts. | ||
| */ | ||
| contract YelayStaking is ReentrancyGuardUpgradeable, YelayOwnable, IYelayStaking, EIP712 { | ||
| contract YelayStaking is ReentrancyGuardUpgradeable, YelayOwnable, IYelayStaking { |
Contributor
Author
There was a problem hiding this comment.
Since EIP712 does not define any storage variables or storage gaps, it can be safely removed from the inheritance chain.
ksamarin90
commented
Sep 18, 2025
| /// @notice Account YLAY locked balance. subset of balances | ||
| mapping(address => uint256) public locked; | ||
|
|
||
| bytes32 private constant _TRANSFER_USER_TYPEHASH = keccak256("TransferUser(address from, uint256 deadline)"); |
Contributor
Author
There was a problem hiding this comment.
constant, not a storage - can be removed.
|
Overall, nice work! It seems like the implementation addreses are swapped. Other than that, I wrote a few suggestions to remove some redundant parts that appeared after the feature was removed :) |
orlicekm
requested changes
Sep 19, 2025
| }, | ||
| "YelayStaking": { | ||
| "implementation": "0x7fc74Dc0b8755f17BaFCaF92DfeD7Fd2cC5Cabf5", | ||
| "implementation": "0x3D79fBbF918327968e75dD0F5b1D25ac65c8dfA2", |
There was a problem hiding this comment.
Addresses are swapped, this one is sYLAY, and sYLAYs one is YelayStaking
There was a problem hiding this comment.
Can UserTransferred be removed as well?
There was a problem hiding this comment.
Can _userExists function be removed as well?
orlicekm
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.