Add test coverage for flush on fluentbit termination#3
Merged
Conversation
Creates 25 pods (50 S3 buffers with 2 outputs), kills fluent-bit with grace-period=15, and verifies all markers appear in S3. Sequential flush would need ~50-100s, so completion within 15s proves concurrency. Validates each pod marker individually rather than counting grep lines, avoiding false positives from duplicate log reads. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
solsson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Efficient flush is essential for raising
total_file_sizeandupload_timeoutto save on blob store operations cost, that is typically per request. With larger buffers we must know that we can flush them given a graceful termination timeout, which for https://kubernetes.io/docs/concepts/cluster-administration/node-shutdown/#graceful-node-shutdown is typically ~20s.