fix some functionality with clearances#63
Conversation
1. Some search algorithms that accepted `clearance` as a parameter did not pass it along to `getNeighbours`, resulting in neighbors being selected when they shouldn't have been. 2. The Theta-star algorithm did not handle clearance at all because it passed an extra incorrect parameter to `isWalkableAt`.
|
it seems this PR was merged!? |
|
@mokalux It wasn't merged in this repository; the latest commit in the master branch was in 2019. Was it merged in a fork? |
|
yes that is weird, I may have gotten an updated version of jumper from the author on a forum (Gideros in my case) and all the PRs you guys made are in my version of jumper! I may have compared my version vs your PR and wrongly assumed they were merged! Sorry for the inconvenience! for ref the forum link: https://forum.gideros.rocks/discussion/1081/jumper-very-fast-pathfinder-for-2d-grid-based-games/p1 |
|
It's all good. Thank you for the link! EDIT: I don't see a separate download link on that forum thread. Where did you get the updated version? |
|
I went through the forum link again and indeed all the jumper links seem to be broken. I come to the conclusion I may have added all your guys PRs into my own manually! |
2 participants
clearanceas a parameter did not pass it along togetNeighbours, resulting in neighbors being selected when they shouldn't have been.isWalkableAt.