Dev

[VampireChicken12]

Summary by CodeRabbit

• Localization

  • Updated Italian, Swedish, and Simplified Chinese translations across multiple settings and labels.
  • Refreshed translation coverage percentages for several locales (e.g., Swedish now complete).

• Improvements

  • Restored and refined fullscreen scrolling behavior for a smoother viewing experience.

• Bug Fixes

  • More reliable enable/disable handling for fullscreen scrolling.
  • Stabilized feature initialization timing on embedded pages to reduce race conditions.

• Browser Compatibility

  • Firefox manifest updated to reflect no required data collection permissions for improved transparency.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Localization files for it-IT, sv-SE, and zh-CN were updated. The restoreFullscreenScrolling feature was refactored to async class-based enable/disable with new CSS. Locale percentage constants changed; i18n hostname access was slightly refactored. Firefox manifest gained data_collection_permissions with corresponding TypeScript ambient types. Embedded feature initialization sequence was adjusted.

Changes

Cohort / File(s)	Summary of edits
Localization updates public/locales/it-IT.json, public/locales/sv-SE.json, public/locales/zh-CN.json, src/i18n/constants.ts, src/i18n/index.ts	Translated multiple UI strings to Italian, Swedish, and Chinese. Updated localePercentages mappings for several locales. Minor refactor for extracting window hostname in i18n initialization (no behavior change).
Restore fullscreen scrolling feature src/features/restoreFullscreenScrolling/index.ts, src/features/restoreFullscreenScrolling/index.css, src/pages/embedded/index.ts	Switched from attribute-based to class-based async toggling using a helper. Added CSS to support fullscreen scrolling layout/overflow. In embedded page, awaited disable operation and adjusted sequencing of batch feature initialization.
Manifest and typings src/manifest.ts, src/global.d.ts	Added Firefox-specific data_collection_permissions to manifestV2. Introduced ambient module/type declarations for collection permissions and Firefox-specific manifest properties.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant EP as Embedded Page
  participant FM as Feature Manager
  participant RFS as restoreFullscreenScrolling
  participant DOM as Document

  U->>EP: Load embedded page
  EP->>FM: enableFeatures()
  FM->>FM: Enable base/built-in features
  FM->>RFS: disableRestoreFullscreenScrolling() (await)
  RFS->>DOM: waitFor ytd-watch-flexy, ytd-app
  RFS->>DOM: Remove RFS classes
  RFS-->>FM: resolved

  note over FM,EP: After base features:
  FM->>FM: Promise.all(additional feature init)
  FM-->>EP: ready

Loading

sequenceDiagram
  autonumber
  participant BG as Background/Options
  participant CT as Content Script
  participant RFS as restoreFullscreenScrolling
  participant DOM as Document

  BG-->>CT: Message with RFS option enabled
  CT->>RFS: enableRestoreFullscreenScrolling() (await)
  RFS->>DOM: waitFor ytd-watch-flexy, ytd-app
  RFS->>DOM: Add RFS classes (classList)
  RFS-->>CT: resolved

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Changed the translations too #855 — Also updates the same locale JSON files; likely part of ongoing translation adjustments.
• Fix ESLint issues #773 — Touches localization files, i18n constants, and embedded feature sequencing including restoreFullscreenScrolling behavior.

Poem

A bunny flips through strings so neat,
Adds classes, scrolls—full-screen’s a treat.
In Firefox burrows, permissions align,
Percentages hop to a fresher design.
With whiskers twitching, features queue—
Async dreams come hopping through. 🐇✨

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dev

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c10f146 and 34b8504.

⛔ Files ignored due to path filters (3)

• assets/translation context screenshots/Miscellaneous Settings/Hide_Playlists_From_Homepage.png is excluded by !**/*.png
• assets/translation context screenshots/Miscellaneous Settings/Restore_Fullscreen_Scrolling.png is excluded by !**/*.png
• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (10)

• public/locales/it-IT.json (2 hunks)
• public/locales/sv-SE.json (5 hunks)
• public/locales/zh-CN.json (2 hunks)
• src/features/restoreFullscreenScrolling/index.css (1 hunks)
• src/features/restoreFullscreenScrolling/index.ts (2 hunks)
• src/global.d.ts (1 hunks)
• src/i18n/constants.ts (1 hunks)
• src/i18n/index.ts (1 hunks)
• src/manifest.ts (1 hunks)
• src/pages/embedded/index.ts (2 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🎉 This PR is included in version 1.28.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀