-
Notifications
You must be signed in to change notification settings - Fork 13
Add map-specific player overview breakdown details #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lordscarlet
wants to merge
17
commits into
YourDeveloperFriend:main
Choose a base branch
from
lordscarlet:feature/map-specific-breakdown-details
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
faf7d7d
Merge pull request #1 from YourDeveloperFriend/main
lordscarlet ee5a76d
Merge pull request #2 from YourDeveloperFriend/main
lordscarlet 680fa3c
Merge remote-tracking branch 'upstream/main'
lordscarlet b0b8c22
Merge remote-tracking branch 'upstream/main'
lordscarlet f023804
Add map-specific breakdown details and multiplier fixes
lordscarlet 309cc2c
Add unit tests for multipliers and breakdown math
lordscarlet a1f3a4a
Add smoke e2e coverage for player overview breakdowns
lordscarlet ae40daa
Display monsoon probabilities as percentages with odds (e.g., 67% (2 …
lordscarlet a20c852
Add e2e artifacts to gitignore
lordscarlet 9eca900
Fix gitignore formatting - separate *.tsbuildinfo and src/e2e/artifacts/
lordscarlet cba25fd
Address PR review: use multiplier hooks in base score calculations
lordscarlet cccded9
Address PR threads for map breakdown follow-ups
lordscarlet 3e78d85
Fix test compilation by isolating monsoon scenarios from client depen…
lordscarlet 9319c09
Merge branch 'main' into feature/map-specific-breakdown-details
lordscarlet f204e16
Merge upstream/main into feature/map-specific-breakdown-details
lordscarlet 6159fcb
Merge origin/feature/map-specific-breakdown-details into feature/map-…
lordscarlet 91a5330
Fix PR 230 CI failures: format files and remove unused export
lordscarlet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,4 +7,5 @@ builds | |
| buildmeta.* | ||
| *.swp | ||
| *.tsbuildinfo | ||
| src/e2e/artifacts/ | ||
| scripts/seed_map_ratings_from_csv.js | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we able to move this map-specific "monsoon scenarios" behavior into the map and make this a more generic extension point (similar to the custom expense items)? My hope is that that would also let us move the new monsoon-specific CSS into a map-specific CSS module as well.