Task 2 by YurikMurik · Pull Request #2 · YurikMurik/angular_global_04_20

YurikMurik · 2020-05-03T13:36:11Z

Added simple routing for components
Changed the structure of components and modules in project
Added pipe for time transforming
Implemented markup + styles + logic for all project's components

Yauhenia-Zhdanovich · 2020-05-04T19:08:15Z

+@Pipe({name: 'transformMinutesToHours'})
+export class TransformMinutesToHoursPipe implements PipeTransform {
+  public transform(time: number): string {
+    if (time < 60) {


убираем волшебные числа в константы

добавил const MINUTE_IN_SEC: number = 60

Yauhenia-Zhdanovich · 2020-05-04T19:11:18Z

+})
+export class CourseItemComponent {
+  @Input() public item: CourseItemInfo;
+  @Input() public routerLink: object;


object убрать, заменить типом

заменил на тип Router

Yauhenia-Zhdanovich · 2020-05-04T19:11:31Z

+export class CourseItemComponent {
+  @Input() public item: CourseItemInfo;
+  @Input() public routerLink: object;
+  @Output() public onDeleteCourse: EventEmitter<number> = new EventEmitter<number>();


@output() public onDeleteCourse: EventEmitter = new EventEmitter();

@output() public onDeleteCourse: EventEmitter = new EventEmitter();

пофиксил

Yauhenia-Zhdanovich · 2020-05-04T19:13:02Z

+    <app-course-item 
+        (onDeleteCourse)="onDeleteCourse($event)"
+        *ngFor="let item of courses"
+        [item] = 'item'


double quotes html

double quotes html

done

Yauhenia-Zhdanovich · 2020-05-04T19:21:33Z

+  public faSearchIcon: IconDefinition = faSearch;
+
+  public searchCourses(e: Event, value: string): void {
+    e.preventDefault();


а зачем тут preventDefault?

а зачем тут preventDefault?

поменял метод, теперь он просто делает console.log значения переменной, которая завязана на изменения в инпуте серча

Yauhenia-Zhdanovich · 2020-05-04T19:23:23Z

@@ -1 +1,7 @@
-<p>search works!</p>
+<div class="toolbox-search">
+    <form>


для одного инпута не нужно добавлять форму

для одного инпута не нужно добавлять форму

пофиксил

Yauhenia-Zhdanovich · 2020-05-04T19:28:41Z

+            <fa-icon [icon]="editButtonIcon"></fa-icon> 
+            Edit
+        </button>
+        <button (click)="onDeleteCourse.emit(item.id)">


emit заворачиваем в метод и вызываем из ts файла

emit заворачиваем в метод и вызываем из ts файла

пофиксил

- Added simple routing for compnonents - Changed the structure of components and modules in project - Added pipe for time transforming - Implemented markup + styles + logic for all project's components

Yauhenia-Zhdanovich reviewed May 4, 2020

View reviewed changes

YurikMurik changed the base branch from master to task-1 May 4, 2020 19:11

YurikMurik force-pushed the task-2 branch from e280e82 to de7e5d7 Compare May 4, 2020 21:23

Yauhenia-Zhdanovich reviewed May 5, 2020

View reviewed changes

YurikMurik force-pushed the task-2 branch 2 times, most recently from b63576d to 0eb6965 Compare May 5, 2020 10:42

Task 2:

7c29ae2

- Added simple routing for compnonents - Changed the structure of components and modules in project - Added pipe for time transforming - Implemented markup + styles + logic for all project's components

YurikMurik force-pushed the task-2 branch from 0eb6965 to 7c29ae2 Compare May 5, 2020 12:47

Conversation

YurikMurik commented May 3, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants