Task 5#4
Open
YurikMurik wants to merge 4 commits intotask-4from
Open
Conversation
Owner
YurikMurik
commented
May 12, 2020
YurikMurik
commented
- Added new service in according to requirements
- Made some refactoring in the base code
- Implemented loginpage + logic for it
- Added logic for header component
- Added modalwindow which show when you try to delete a course from the courseList
added 2 commits
May 16, 2020 22:13
| return this.isAuthentificated(); | ||
| } | ||
|
|
||
| public isAuthentificated(): Observable<boolean> { |
There was a problem hiding this comment.
this method should not return observable, just boolean value
| import { IconDefinition, faUser, faArrowRight, faAddressCard } from '@fortawesome/free-solid-svg-icons'; | ||
| import { AuthService } from 'src/app/core/services/auth.service'; | ||
| import { UserInfo } from 'src/app/core/models/user-info.interface'; | ||
| import { switchMap } from 'rxjs/operators'; |
There was a problem hiding this comment.
please delete unused imports
| }) | ||
| export class HeaderLoginComponent { | ||
| export class HeaderLoginComponent implements OnInit { | ||
| @Input() public isAuthentificated: boolean; |
There was a problem hiding this comment.
не совсем понимаю, зачем тебе инпут, если у тебя все равно заимпортан сервис. Может лучше сделать запрос на isAuthentificated через сервис в ngOnInit()?
|
|
||
| export class HeaderComponent implements OnInit { | ||
| @Input() public currentRouteUrl: string; | ||
| public authentification: boolean = false; |
There was a problem hiding this comment.
неинформативное название проперти
Owner
Author
There was a problem hiding this comment.
заменил на isAuthentificated
| }); | ||
| } | ||
|
|
||
| public ngDoCheck(): void { |
Owner
Author
There was a problem hiding this comment.
пофикшено. теперь красиво
- Refactoring of services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.