Open
Conversation
resolved a threadlock issue where no timeout was applied before attempting to establish a connection to the KMNet Device
Owner
|
I have never had any missed responses with the initialization when that event occurs to you? |
Author
If one were to call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a small but important change to the
kmNet_initfunction in thekmboxNet.cppfile to improve network communication reliability. Specifically, it sets a timeout for receiving data on the socket. This prevents any application using the KMNet library from encountering a threadlock due to a device connection failing.kmboxNet.cpp: Added aSO_RCVTIMEOsocket option to set a 3-second timeout for receiving data, ensuring the function does not hang indefinitely if no response is received.