Skip to content

Fix parsing zip64 extra field#209

Open
kinolaev wants to merge 1 commit into
ZJONSSON:masterfrom
kinolaev:patch-1
Open

Fix parsing zip64 extra field#209
kinolaev wants to merge 1 commit into
ZJONSSON:masterfrom
kinolaev:patch-1

Conversation

@kinolaev

@kinolaev kinolaev commented Jul 8, 2020

Copy link
Copy Markdown

Hello,

fields can be omitted in the zip64 extra field, see https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT, 4.5.3.

Thank you for great work!

@mrbabbs

mrbabbs commented Jul 18, 2020

Copy link
Copy Markdown

@ZJONSSON it would be nice if you can merge this PR.
I have tested on node version 12 and fix for me the problem of extracting a file > 4 GB.

@amsoedal

amsoedal commented Aug 3, 2020

Copy link
Copy Markdown

@ZJONSSON we believe this would fix the FILE_ENDED issue we are seeing as well. Would it be possible to have it looked at? Thanks!
Edit: looks like one of the build jobs is failing?

@theill

theill commented Mar 28, 2021

Copy link
Copy Markdown

@ZJONSSON - It would be awesome to have this PR merged. We've tested it extensively and running it in production.

@mtinnes

mtinnes commented Aug 3, 2021

Copy link
Copy Markdown

Any chance this can get merged soonish? please and ty

@pgbce

pgbce commented Sep 10, 2021

Copy link
Copy Markdown

@ZJONSSON any chance of merging this in? This would be quite helpful. Please

@anderson-arlen

Copy link
Copy Markdown

@kinolaev Thanks for this. This fixes FILE_ENDED issues I'm having.

@ZJONSSON Please merge this.

nosferatu500 added a commit to nosferatu500/unzipper that referenced this pull request May 9, 2022
@yocontra

yocontra commented Jun 5, 2022

Copy link
Copy Markdown

@kinolaev Is this fixed by #244 or does it still need to be applied?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants