fix:系统文件对话框关闭后,主窗口自动显示#474
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a centralized openDialog utility in windowUtils.ts to replace direct Electron dialog.showOpenDialog calls across multiple renderer API files, standardizing dialog handling and result processing. Review feedback recommends using BrowserWindow instead of BaseWindow for type consistency and adding a safety check to ensure the parent window is not destroyed before calling show(). A non-null assertion for mainWindow in localShortcuts.ts was also suggested for consistency.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
在关闭系统文件对话框后,显示主窗口,便于后续操作。例如在添加本地启动后,需要对启动项指定别名。这可能更符合多数用户的使用习惯