feat(setting): 匹配指令的详情信息页#494
Merged
lzx8589561 merged 3 commits intoMay 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new MatchCommandDetailDialog component to display detailed configuration for various command types (regex, files, window, etc.) and integrates it into the plugin detail and command settings views. Key improvements include better type safety for command matching and helper functions for extracting command metadata. Feedback focuses on refactoring opportunities: extracting hardcoded Chinese strings for internationalization, unifying duplicate type definitions for MatchCmd across files, and consolidating repeated dialog logic into a shared composable to reduce code redundancy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更内容
给【全部指令】页和插件详情页指令的下拉菜单,添加 【详细信息】选项以及对应的对话框
动机
方便用户查看各【匹配指令】的具体匹配条件,从而方便用户快速上手插件。
截图
相关issue