fix(setting): 修复全局快捷键取词时机#508
Merged
lzx8589561 merged 2 commits intoMay 31, 2026
Merged
Conversation
等待全局快捷键按键释放后再执行复制取词,并在快捷键注册期间保持键盘状态监听,避免修饰键残留导致取词异常或卡住。
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a system to capture selected text context upon global shortcut activation by simulating a copy command and monitoring the clipboard. It adds shortcut cooldowns, key release detection, and a sequence-based clipboard update waiter. Feedback from the review highlights the need for timeouts in asynchronous wait functions to prevent potential hangs, recommends triggering context capture conditionally to avoid side effects on unrelated shortcuts, and suggests removing debug logs.
按需采集文本上下文,并为键盘/剪贴板等待补充超时,降低无关快捷键副作用和处理链路挂起风险。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
等待全局快捷键按键释放后再执行复制取词,并在快捷键注册期间保持键盘状态监听,避免修饰键残留导致取词异常或卡住。