Skip to content

[Feat] 本地启动支持一键清除失效项#557

Open
Flinglin wants to merge 7 commits into
ZToolsCenter:mainfrom
Flinglin:feat/failure-detection
Open

[Feat] 本地启动支持一键清除失效项#557
Flinglin wants to merge 7 commits into
ZToolsCenter:mainfrom
Flinglin:feat/failure-detection

Conversation

@Flinglin

Copy link
Copy Markdown
Contributor

#478 中的失效项检测

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a feature to clean up invalid local shortcuts by checking if their target paths exist and deleting them if they do not. It adds a 'Delete invalid items' button to the UI, exposes a new deleteWhenNotExist IPC channel, and implements the deletion logic in the main process. The review feedback highlights several critical improvements: avoiding synchronous file checks (existsSync) in the Electron main process to prevent UI blocking, adding a confirmation dialog for safety before bulk deletion, ensuring robust state management using a finally block, and cleaning up redundant imports and syntax inconsistencies in the preload script.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/api/renderer/localShortcuts.ts
Comment thread resources/preload.js Outdated
Comment thread resources/preload.js Outdated
Comment thread src/main/api/renderer/localShortcuts.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant