Securiy Patch: Patched a potential security flaw with logs#76
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This security patch introduces a LogSanitizer utility class to prevent log injection attacks by sanitizing user-controlled data before it is written to logs. The sanitizer removes control characters and escapes newlines, ensuring that attackers cannot forge log entries or hide malicious activity through crafted input containing newline characters.
Key changes:
- Added
LogSanitizer.Sanitize()method that removes control characters and converts CR/LF to visible escape sequences - Applied sanitization to all log statements that include user-controlled data (dashboard titles, section names, button text, API responses, URLs)
- Protected against log injection vulnerabilities across multiple controllers
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Dashy.Net.ApiService/Infrastructure/LogSanitizer.cs | New utility class that sanitizes values for safe logging by removing control characters and escaping newlines |
| Dashy.Net.ApiService/Controllers/WeatherController.cs | Sanitizes external API URLs and error responses before logging |
| Dashy.Net.ApiService/Controllers/SectionsController.cs | Sanitizes section names (user input) in create and delete log statements |
| Dashy.Net.ApiService/Controllers/HeaderButtonsController.cs | Sanitizes header button text (user input) in create log statement |
| Dashy.Net.ApiService/Controllers/DashboardController.cs | Sanitizes dashboard title (user input) in create log statement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Cato Myhre <catomyhre@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.