Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to improve missing-document handling by returning an HTTP 404 status for non-existent pages, and bumps the application version accordingly.
Changes:
- Bump application version from
1.0.87to1.0.88. - Call
http_response_code(404)when rendering a non-homepage document that doesn’t exist.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
VERSION |
Updates the project version to 1.0.88. |
classes/Document.class.php |
Attempts to set HTTP 404 status when a requested document is not found. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi, After testing version 89 (uploaded manually to cPanel), I found that the CSRF protection error still blocks DELETE and EDIT actions. · Create works ✅ Since the problem is not solved, and I cannot validate the fix without Git or local testing environment (my workflow is download → upload to cPanel → manual setup), I am cancelling this pull request. It doesn't make sense to proceed from v88 to v89 if core actions remain broken. Please let me know when a more stable version is available. Thank you for understanding. |
|
Sorry i am not trying to open a PR for this yet i have found a fix for that issue but this particular PR is still open so i am waiting for the review to be done please use stable .83 till then. |
|
@ffiesta this PR is only for the 404 error, if you approve the review i will merge it! |
ffiesta
left a comment
There was a problem hiding this comment.
Hi,
I won't undersant this big changes, and why AI delete and add same code!. but if you need that F12 > Network > status [404] NOT OK (my version future 89 version, it continue to show 200 on status.), but it show 404 ou body of the page.
|
I think it was converted tab to spaces, I have added only one line just has you suggested in the issue |
This pull request includes a minor version bump and an improvement to error handling for missing documents. The most important changes are:
Error Handling:
rendermethod inDocument.class.phpnow explicitly sets the HTTP response code to 404, ensuring that clients and search engines correctly recognize missing pages.Version Update:
VERSIONfile has been updated from1.0.87to1.0.88to reflect these changes.