Skip to content

fix-283#296

Open
Zavy86 wants to merge 3 commits into
masterfrom
fix-283
Open

fix-283#296
Zavy86 wants to merge 3 commits into
masterfrom
fix-283

Conversation

@Zavy86
Copy link
Copy Markdown
Owner

@Zavy86 Zavy86 commented May 26, 2026

This pull request includes a minor version bump and an improvement to error handling for missing documents. The most important changes are:

Error Handling:

  • When a document is not found, the render method in Document.class.php now explicitly sets the HTTP response code to 404, ensuring that clients and search engines correctly recognize missing pages.

Version Update:

  • The VERSION file has been updated from 1.0.87 to 1.0.88 to reflect these changes.

@Zavy86 Zavy86 linked an issue May 26, 2026 that may be closed by this pull request
1 task
@Zavy86 Zavy86 requested review from Copilot and leomoon May 26, 2026 06:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to improve missing-document handling by returning an HTTP 404 status for non-existent pages, and bumps the application version accordingly.

Changes:

  • Bump application version from 1.0.87 to 1.0.88.
  • Call http_response_code(404) when rendering a non-homepage document that doesn’t exist.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
VERSION Updates the project version to 1.0.88.
classes/Document.class.php Attempts to set HTTP 404 status when a requested document is not found.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread classes/Document.class.php Outdated

This comment was marked as off-topic.

00PrabalK00 added a commit to 00PrabalK00/WikiDocs that referenced this pull request May 26, 2026
@Zavy86 Zavy86 requested a review from ffiesta May 26, 2026 13:54
@ffiesta
Copy link
Copy Markdown
Collaborator

ffiesta commented May 26, 2026

Hi,

After testing version 89 (uploaded manually to cPanel), I found that the CSRF protection error still blocks DELETE and EDIT actions.

· Create works ✅
· Edit fails ❌ (CSRF triggered)
· Delete fails ❌ (CSRF triggered)

Since the problem is not solved, and I cannot validate the fix without Git or local testing environment (my workflow is download → upload to cPanel → manual setup), I am cancelling this pull request.

It doesn't make sense to proceed from v88 to v89 if core actions remain broken.

Please let me know when a more stable version is available.

Thank you for understanding.

@00PrabalK00
Copy link
Copy Markdown
Contributor

Sorry i am not trying to open a PR for this yet i have found a fix for that issue but this particular PR is still open so i am waiting for the review to be done please use stable .83 till then.

@Zavy86
Copy link
Copy Markdown
Owner Author

Zavy86 commented May 27, 2026

@ffiesta this PR is only for the 404 error, if you approve the review i will merge it!

Copy link
Copy Markdown
Collaborator

@ffiesta ffiesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I won't undersant this big changes, and why AI delete and add same code!. but if you need that F12 > Network > status [404] NOT OK (my version future 89 version, it continue to show 200 on status.), but it show 404 ou body of the page.

@Zavy86
Copy link
Copy Markdown
Owner Author

Zavy86 commented May 27, 2026

I think it was converted tab to spaces, I have added only one line just has you suggested in the issue

@Zavy86 Zavy86 requested a review from ffiesta May 27, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect HTTP code on 404

4 participants