You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR removes unused variables and parameters across tests and service handlers to improve code cleanliness and satisfy linter rules.
Found unused variables in TypeScript code: various unused imports (afterEach, embeddingService) and promise assignments from service.warmup were removed; the mock implementation callback signature was simplified by dropping unused arguments; the optional userId parameter in handleRefreshProfile was prefixed with an underscore to denote it’s intentionally unused; and string replacement logic was corrected to properly escape backslashes.
This Autofix was generated by AI. Please review the change before merging.
This PR removes unused variables and parameters across tests and service handlers to improve code cleanliness and satisfy linter rules.
- Found unused variables in TypeScript code: various unused imports (`afterEach`, `embeddingService`) and promise assignments from `service.warmup` were removed; the mock implementation callback signature was simplified by dropping unused arguments; the optional `userId` parameter in `handleRefreshProfile` was prefixed with an underscore to denote it’s intentionally unused; and string replacement logic was corrected to properly escape backslashes.
> This Autofix was generated by AI. Please review the change before merging.
We reviewed changes in 7918013...4324e79 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
The reason will be displayed to describe this comment to others. Learn more.
Unexpected any. Specify a different type
The any type can sometimes leak into your codebase. TypeScript compiler skips the type checking of the any typed variables, so it creates a potential safety hole, and source of bugs in your codebase. We recommend using unknown or never type variable.
Closing due to a bug: the escapeLikePattern change in user-prompt-manager.ts incorrectly doubles the backslash escaping (String.raw), which would break LIKE pattern escaping. The other 3 changes are fine — please re-open with the escapeLikePattern change reverted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![deepsource-io[bot]](https://avatars.githubusercontent.com/in/16372?s=60&v=4){kind=small}
This PR removes unused variables and parameters across tests and service handlers to improve code cleanliness and satisfy linter rules.
afterEach,embeddingService) and promise assignments fromservice.warmupwere removed; the mock implementation callback signature was simplified by dropping unused arguments; the optionaluserIdparameter inhandleRefreshProfilewas prefixed with an underscore to denote it’s intentionally unused; and string replacement logic was corrected to properly escape backslashes.