Skip to content

fix: guard initConfig against silent config reset on empty file load #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bob56621517 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: guard initConfig against silent config reset on empty file load #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,17 @@ export function initConfig(directory: string): void {
];
const globalConfig = loadConfigFromPaths(CONFIG_FILES);
const projectConfig = loadConfigFromPaths(projectPaths);

// Guard: if neither global nor project config files were found (transient I/O
// failure, race condition, or missing files), do NOT rebuild the entire CONFIG
// from scratch. Calling buildConfig({}) with an empty object fills every field
// with hardcoded defaults — silently overwriting user-configured embedding
// dimensions, model, and API endpoint. The CONFIG singleton already carries
// the correct values from module-level initialization (line 593).
if (Object.keys(globalConfig).length === 0 && Object.keys(projectConfig).length === 0) {
return;
}

const merged = deepMerge(globalConfig, projectConfig);
Object.assign(CONFIG, buildConfig(merged));
}
Expand Down