bugfix LiveDataset size mismatch in Coops#303
Open
BasDekker-Zenmo wants to merge 3 commits into
Open
Conversation
- Created a class DataSetConstructor with a static method to get a new liveweek data set, which has values zero for all timesteps in the past. - In the class J_LiveData the method clearLiveDataSets has been renamed to resetLiveDataSets to conform with the naming of AnyLogic's DataSet - The old method resetLiveDataSets has been renamed to createNewLiveDataSets, it uses the above mentioned constructor. - Removed f_initializeDataSets in the GridConnection as this function is now a one-liner call on liveData. - f_collectGridConnectionLiveData in the EnergyCoop has been refactored. The previous commits in this PR solved the bug, but the .get(0) was still bothering me. The loop size and time variables are now calculated from information from J_TimeParameters and J_TimeVariables - Renamed the helper functions f_addConsumptionEnergyCarrier, f_addProductionEnergyCarrier, f_addAssetFlow to specify AfterInitialization.. - TODO: Cleanup the timeParameters & timeVariables arguments and check for changes that effect other packages.
- Moved the helper functions f_addConsumptionEnergyCarrier, f_addProductionEnergyCarrier, f_addAssetFlow to J_LiveData. Now they share one implementation between the GC, EnergyCoop & EnergyModel - Added timeParameters as arguments to several functions, including functions that are called from interface package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Luc-Sol Ik heb dit samen gemaakt met @AteZenmo . Deze bug kwam ook voor bij onpauzeren van GCs in combinatie met het gebruik van de filter functie voordat de nieuwe/ongepauzeerde GC een week gerunt heeft. Betreft issue: Zenmo/zero_Interface-Loader#285