Typedefs #5648
Typedefs #5648
Conversation
units/bomberassault.lua
Outdated
| manualfire_desc = [[Fire Special Weapon: Fire a cluster of temporary shield generators.]], | ||
| }, | ||
|
|
||
| selfDestructAs = [[ESTOR_BUILDING]], |
There was a problem hiding this comment.
This should become explodeAs rather than deleted. I applied that change directly to master though, thanks for noticing. dc91e3a
| @@ -0,0 +1,3 @@ | |||
| [submodule "recoil-lua-library"] | |||
There was a problem hiding this comment.
Scary, do submodules with with stuff like rapid or infra steam depot?
| return chunk, str2 | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
random whitespace change in an otherwise untouched file, here and in unit_tech_k.lua
|
I am not sure about this. It needs a well written tutorial on the wiki for how to set it up. Also I am concerned that this will just bitrot. |
|
Now Im not sure about it as well... we can have typedefs files elsewhere (we can set .luarc.json), |
…X.SMOKE + SFX.EXPLODE)
|
It isn't a matter of whether there should be a tutorial or it should be in the repository. If this were pulled right now, I would have no idea how to use it, and I doubt anyone else would either. It would amount to a bunch of weird files sitting around for no reason. So a tutorial for how to use this is required. Alternately it might be better as a standalone module and a tutorial. This would let you release this at whatever rate you want. But a tutorial is needed either way. Another problem is that this PR contains a bunch of random bugfixes and whitespace changes. |
| --constants | ||
| local rotorSpeed = math.rad(1080) | ||
| local rotorAccel = math.rad(240) | ||
| local pivotSpeed = math.rad(180) |
There was a problem hiding this comment.
This isn't a noop like the other fixes.
|
I've applied the fixes: 7f7ce19 As far as I can tell, three were issues hurting nobody (eg passing nil rather than false), one just amounts to letting enemy units scout the spin bar on DRP, and another was wrong. If this tool is mainly for fixes like these (which idk, maybe it is) then it isn't giving us much. All I can see now is a barrier for entry and maintenance headache. |
3 participants
Added typedefs file and .luarc.json for vscode Lua Language Server. Now Lua Language Server can find some actual bugs, and provides comments.