fix(imap): 修复验证码提取详情错配#67
Open
hongdongjian wants to merge 1 commit into
Open
Conversation
Owner
|
总体结论:修复方向正确,批量 IMAP 返回按 关键发现:
优先级建议:
后续建议:
|
Owner
|
CodeXWeb 本轮自动巡检已认领,正在处理本 PR 的 review 修改意见。 本轮只会处理这一项:#67。处理范围限定为评论 4677387316 中指出的 IMAP detail 缺失/无 id 时未重取 latest 详情及对应回归测试;不会自动合并。 |
ZeroPointSix
left a comment
Owner
There was a problem hiding this comment.
CodeXWeb 本轮自动巡检处理结果:已按 review comment 4677387316 做最小修复并验证。
处理内容:
- 将 IMAP detail 重取条件调整为:只要存在
latest_id且当前detail_id != latest_id就重新按 latest 邮件 id 获取详情,覆盖detail=None、空对象或无 id 的情况。 - 新增回归测试
test_imap_missing_detail_refetches_latest_message_detail,覆盖 batch 返回最新邮件列表但未带回 detail 时仍能按 latest id 重取并提取验证码。 - 已同步更新
WORKSPACE.md操作记录。
提交状态:
- 本地提交:
3fa2bdf(fix(imap): refetch latest detail when missing) - 由于 PR #67 当前 head 仍停在
30dd2f867db43645058c44e8596d78251704f947,且该 PR 作者为hongdongjian,本轮未能直接更新原 PR head 分支。 - 我已将同一提交推送到主仓库分支
ZeroPointSix/outlookEmailPlus:fix/imap-verification-detail-mismatch,可用于 cherry-pick 或重新开/替换 PR 分支。
验证:
git diff --check:通过.venv/bin/python -m pytest tests/test_imap_connection_reuse.py tests/test_verification_extract_log.py -q:19 passed.venv/bin/python -m compileall -q outlook_web web_outlook_app.py outlook_mail_reader.py start.py tests && .venv/bin/python -m unittest discover -s tests -v:执行完成但退出码 1;本次新增/相关验证码提取用例通过,失败集中在既有真实 CF Worker E2E。.venv/bin/python -m unittest tests.test_pool_cf_real_e2e -v:单独复现 4 failures,首个失败为UPSTREAM_BAD_PAYLOAD,上游返回CF Worker 创建邮箱失败 HTTP 400,与本次 IMAP detail 重取改动无直接交集。
本轮未自动合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
修复 IMAP 验证码提取时 matched_email_id 与实际提取正文不一致的问题。
修改
测试