fix: add optional Watchtower Docker API override for Docker 29#80
Merged
Conversation
ZeroPointSix
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DOCKER_API_VERSION=${WATCHTOWER_DOCKER_API_VERSION:-}into the bundled Watchtower service so Docker API overrides are available without disabling negotiation by default.WATCHTOWER_DOCKER_API_VERSION=1.44as an opt-in workaround for Docker 29.0-29.2client version ... too oldfailures, with notes for older Docker Engine users to leave it unset or choose a supported API version.Context
Watchtower's historical Docker client API default can be lower than the Docker Engine 29.0-29.2 minimum, which can produce
client version 1.25 is too old. Minimum supported API version is 1.44and make the app report that it cannot connect tohttp://watchtower:8080.Docker's
DOCKER_API_VERSIONoverride disables API version negotiation when set to a non-empty value, so this PR now leaves the override empty by default and documentsWATCHTOWER_DOCKER_API_VERSION=1.44as the targeted workaround for affected Docker 29 deployments.Closes #79.
Testing
CONNECT tunnel failed, response 403). Verified the changed files through the GitHub connector and added/updatedtests/test_watchtower_compose_contract.pyfor CI.