fix: clarify imported account token status#82
Draft
ZeroPointSix wants to merge 2 commits into
Draft
Conversation
Owner
Author
|
CodeXWeb trace for Issue #78:
This PR is draft and should not be auto-merged. |
Open
|
Owner
Author
|
总体结论:本 PR 的改动范围清晰,和 Issue #78 的用户可见问题一致;本轮未发现阻塞合并的代码问题。 关键发现:
优先级建议:
后续建议:
|
ZeroPointSix
commented
Jun 11, 2026
ZeroPointSix
left a comment
Owner
Author
There was a problem hiding this comment.
总体结论:本轮正式 review 覆盖 PR #82 当前 head fee5848e2d53ca8051dab213fbe73c0fc59a7d58。改动范围和 Issue #78 的用户可见问题一致,未发现阻塞合并的代码问题。
关键发现:
- 已核对
static/js/features/groups.js:可刷新 Outlook 账号在没有token_status时默认显示从“未知”改为“未刷新”,且valid/invalid/expired/refreshing等既有状态分支没有被改动,行为风险集中在展示文案。 - 已核对
static/js/i18n.js:新增未刷新 -> Not refreshed,没有移除或替换既有未知 -> Unknown,因此其他未知状态文案不会被误改。 - 已核对
tests/test_frontend_account_type_and_refresh_suggestions_contract.py:新增正向断言和旧文案回归断言,能覆盖本次 UI 文案回退风险。 - PR 描述声明不涉及账号导入、token refresh、账号删除或号池状态行为;从本次 diff 看也没有触碰这些后端路径,描述与改动一致。
优先级建议:
- 阻塞:无。
- 中:完整测试仍记录
tests/test_pool_cf_real_e2e.py的外部 CF Worker 失败;虽然与本 PR diff 不相邻,合并前建议 maintainer 确认这仍是当前仓库可接受的外部 E2E 状态。 - 低:如果后续有浏览器截图或可视化回归测试,可以补一条导入后未刷新 Outlook 卡片的渲染断言,降低纯字符串合约测试漏掉布局问题的风险。
后续建议:
- 当前 PR 可以继续保持小范围修复;转 ready 前重点确认外部 E2E 失败是否按仓库既有策略豁免,而不是扩展本 PR 去处理无关的 CF Worker 问题。
巡检审查标记:PR & Issue Reviewer 已审查当前 head commit fee5848e2d53ca8051dab213fbe73c0fc59a7d58;本轮对 ZeroPointSix/outlookEmailPlus#82 写回正式 review。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
未知to未刷新.Not refreshed.Design Basis
move_out_of_poolintentionally clearspool_statusbut keeps the account in account management, so the reported pool-count/account-management-count behavior is preserved and not changed here.Validation
.venv/bin/python -m pytest tests/test_frontend_account_type_and_refresh_suggestions_contract.py tests/test_auto_import.py tests/test_pool_admin_service.py-> 40 passed..venv/bin/python -m pytest-> 1523 passed, 7 skipped, 4 failed intests/test_pool_cf_real_e2e.pybecause the real CF Worker returned HTTP 400 /UPSTREAM_BAD_PAYLOADwhile creating mailboxes. This matches the repository's existing historical note for that external E2E file and is not touched by this UI-copy change.git diff --checkpassed before commit.Risk
Notes