Refactor: Extract magic numbers to named constants#37
Open
anaisd5 wants to merge 4 commits into
Open
Conversation
ZeroSumQuant
pushed a commit
that referenced
this pull request
Jan 1, 2026
Combined with PR #37's INDENT_NUMBER constant while preserving ensure_ascii=False for proper Unicode handling.
ZeroSumQuant
pushed a commit
that referenced
this pull request
Jan 1, 2026
Combined with PR #37's SESSION_ID_MAX_LENGTH constant.
ZeroSumQuant
pushed a commit
that referenced
this pull request
Jan 1, 2026
- Implement project filtering with `--project` flag (Issue #38) - Improve Windows compatibility: - Add UTF-8 stdout reconfiguration - Remove Unix-specific code (`realtime_search.py`) - Replace print with logging in `extract_claude_logs.py` (Issue #28) - Add comprehensive type hints (Issue #27) - Fix interactive UI tests by mocking `Path.stat` - Add PDF/DOCX export capabilities (PRs #34, #36, #37 logic integrated) - Support metadata (--title, --description, --tags) and todo extraction - Clean up magic numbers into `constants.py`
sytelus
added a commit
to sytelus/claude-sessions
that referenced
this pull request
Jan 7, 2026
…onstants Combined with PR ZeroSumQuant#36's ensure_ascii=False for proper Unicode handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29
Hello,
This PR refactors the four files mentioned in the issue.
To help with maintainability and reduce the number of 'magic numbers', I added some additional constants beyond those listed in the original example.
I also separated the changes by file into individual commits, so reviewing should be straightforward.
Hope this helps, and happy to adjust if needed!