Implement n8n review feedback for all custom nodes#20
Merged
jaseemjaskp merged 1 commit intomainfrom Dec 12, 2025
Merged
Conversation
This commit addresses all feedback from Jon's n8n node review to ensure compliance with n8n best practices and standards. Changes across all nodes: - Remove custom sleep implementation, import from n8n-workflow - Add usableAsTool property to enable AI agent compatibility - Add resource and operation dropdown parameters with displayOptions - Move optional parameters to Additional Options collections - Implement Continue on Fail error handling pattern Node-specific changes: Unstract.node.ts & UnstractHitlPush.node.ts: - Remove redundant manual Bearer authentication from status polling - Use httpRequestWithAuthentication for all API requests - Remove manual apiKey extraction from credentials - Maintain returnFullResponse and ignoreHttpStatusErrors for 422 handling UnstractHitlFetch.node.ts: - Move HITL Queue Name from Additional Options to required field - Add ignoreHttpStatusErrors to handle 404 responses gracefully - Simplify error handling: return API errors in response instead of throwing - Remove hardcoded error message checks LlmWhisperer.node.ts: - Move 11 optional parameters to Additional Options collection - Maintain alphabetical sorting of options All changes maintain backward compatibility while improving code quality, maintainability, and adherence to n8n conventions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements all feedback from n8n node review to ensure full compliance with n8n best practices and standards.
Changes Made
All Nodes
sleepimplementation, now imported fromn8n-workflowusableAsTool: truefor AI agent compatibilitydisplayOptionsUnstract.node.ts & UnstractHitlPush.node.ts
httpRequestWithAuthenticationapiKeyextraction from credentialsreturnFullResponseandignoreHttpStatusErrorsfor HTTP 422 handlingUnstractHitlFetch.node.ts
ignoreHttpStatusErrors: trueto handle HTTP 404 responses gracefullyLlmWhisperer.node.ts
Testing
usableAsTool: truein compiled outputBreaking Changes
None - all changes maintain backward compatibility.
Related Issue
Fixes #[issue-number] (if applicable)