[FIX] Fix HITL review screen showing "Never expires" despite TTL being set#1785
Merged
vishnuszipstack merged 1 commit intomainfrom Feb 9, 2026
Merged
[FIX] Fix HITL review screen showing "Never expires" despite TTL being set#1785vishnuszipstack merged 1 commit intomainfrom
vishnuszipstack merged 1 commit intomainfrom
Conversation
…g set Fix two interacting bugs that prevented TTL from propagating to HITL queue records: 1. WorkflowUtil.get_hitl_ttl_seconds was an OSS stub that always returned None. Now delegates to get_hitl_ttl_seconds_by_workflow via try/except import, falling back to None in OSS environments. 2. _push_to_queue_for_api_deployment never fetched TTL. Now mirrors the connector path by calling WorkflowUtil.get_hitl_ttl_seconds and passing ttl_seconds through to _create_queue_result and _enqueue_to_packet_or_regular_queue. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
WalkthroughThe changes add pluggable HITL (Human-in-the-Loop) TTL handling to workflow deployments. A utility function now dynamically retrieves TTL values from a cloud-specific helper module when available, falling back gracefully for OSS environments. The API deployment endpoint integrates this TTL computation into queue payload creation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Test ResultsSummary
Runner Tests - Full Report
SDK1 Tests - Full Report
|
|
vishnuszipstack
requested review from
Deepak-Kesavan,
chandrasekharan-zipstack,
jagadeeswaran-zipstack and
muhammad-ali-e
and removed request for
chandrasekharan-zipstack
chandrasekharan-zipstack
approved these changes
Feb 9, 2026
athul-rs
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
WorkflowUtil.get_hitl_ttl_secondsOSS stub to delegate to the realget_hitl_ttl_seconds_by_workflowimplementation_push_to_queue_for_api_deploymentso API deployment path propagates TTL to HITL queue recordsWhy
WorkflowUtil.get_hitl_ttl_secondsis an OSS stub that hardcodesreturn None, even though the real implementation exists inpluggable_apps.manual_review_v2.helper_push_to_queue_for_api_deploymentnever fetches TTL at all, unlike its sibling_push_to_queue_for_connectorHow
utils.py): Changedget_hitl_ttl_secondsto import and callget_hitl_ttl_seconds_by_workflowviatry/except ImportError, so it works in cloud environments and gracefully returnsNonein OSSdestination.py): Addedttl_seconds = WorkflowUtil.get_hitl_ttl_seconds(self.workflow)to the API deployment path and passed it through to_create_queue_resultand_enqueue_to_packet_or_regular_queue, mirroring the existing connector pathCan this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
try/except ImportErrorpattern ensures OSS environments without the pluggable app still getNone(unchanged behavior). The API deployment path previously never set TTL, so adding it is purely additive.Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
postgresql_queue.py enqueue())Dependencies Versions
Notes on Testing
ttl_hoursin HITLSettings for a workflow via the HITL settings UIScreenshots
N/A
Checklist
I have read and understood the Contribution Guidelines.