Make it build with swift build --swift-sdk x86_64-swift-linux-musl#9
Open
doozMen wants to merge 1 commit intoZollerboy1:mainfrom
Open
Make it build with swift build --swift-sdk x86_64-swift-linux-musl#9doozMen wants to merge 1 commit intoZollerboy1:mainfrom
doozMen wants to merge 1 commit intoZollerboy1:mainfrom
Conversation
Zollerboy1
requested changes
Oct 9, 2024
Owner
Zollerboy1
left a comment
Zollerboy1
left a comment
There was a problem hiding this comment.
Looks good to me overall. Please address these two minor issues.
Comment on lines
+28
to
+29
| #elseif os(Windows) | ||
| let read = ucrt.read |
Owner
There was a problem hiding this comment.
Suggested change
| #elseif os(Windows) | |
| let read = ucrt.read |
We are already in an #if !os(Windows) here.
Comment on lines
+14
to
+16
| #elseif os(Windows) | ||
| import ucrt | ||
| #else |
Owner
There was a problem hiding this comment.
Suggested change
| #elseif os(Windows) | |
| import ucrt | |
| #else | |
| #elseif !os(Windows) |
ucrt isn't used at all in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followed instructions at https://www.swift.org/documentation/articles/static-linux-getting-started.html
This will make it possible to build static linux libs without dependency on swift